Page MenuHomePhabricator

Remove obsolete, nonfunctional draft auto-saving in Phriction
ClosedPublic

Authored by epriestley on Sep 11 2018, 4:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 24 2024, 5:04 PM
Unknown Object (File)
Feb 12 2024, 4:09 PM
Unknown Object (File)
Feb 11 2024, 11:55 PM
Unknown Object (File)
Dec 24 2023, 12:18 AM
Unknown Object (File)
Dec 22 2023, 12:21 AM
Unknown Object (File)
Dec 21 2023, 6:12 PM
Unknown Object (File)
Dec 21 2023, 5:28 AM
Unknown Object (File)
Dec 15 2023, 12:25 PM
Subscribers
None

Details

Summary

Depends on D19660. Ref T5811. Ref T13077.

Long ago, if you started editing a Phriction document but didn't save it, we'd save the draft in the background as part of the preview.

D11169 updated the preview to use shared infrastructure and broke this function, since we never save drafts.

Since this doesn't work right now, I want to add another thing called "draft", and the future of this feature should be more integrated with modern drafts and EditEngine (which fixed some bugs related to versioning), just get rid of this code for the moment.

Test Plan

Edited documents. This code doesn't do anything since D11169, so no behavior changed.

Diff Detail

Repository
rP Phabricator
Branch
wiki3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20791
Build 28276: Run Core Tests
Build 28275: arc lint + arc unit