Page MenuHomePhabricator

Support an "Ancestors Of: ..." constraint in commit queries
ClosedPublic

Authored by epriestley on May 7 2018, 8:50 PM.
Tags
None
Referenced Files
F18096405: D19431.id46487.diff
Fri, Aug 8, 6:43 AM
F18093575: D19431.id46481.diff
Thu, Aug 7, 7:28 PM
F18092871: D19431.id.diff
Thu, Aug 7, 1:39 PM
F18090789: D19431.diff
Wed, Aug 6, 5:33 PM
Unknown Object (File)
Jun 29 2025, 12:41 AM
Unknown Object (File)
Jun 28 2025, 6:06 PM
Unknown Object (File)
Jun 28 2025, 1:14 PM
Unknown Object (File)
Jun 27 2025, 4:06 PM
Subscribers
None

Details

Summary

Ref T13137. See PHI609. An install would like to filter audit requests on a particular branch, e.g. "master".

This is difficult in the general case because we can not apply this constraint efficiently under every conceivable data shape, but we can do a reasonable job in most practical cases.

See T13137#238822 for more detailed discussion on the approach here.

This is a bit rough, but should do the job for now.

Test Plan
  • Filtered commits by various branches, e.g. "master"; "lfs". Saw correct-seeming results.
  • Stubbed out the "just list everything" path to hit the diffusion.internal.ancestors path, saw the same correct-seeming results.

Diff Detail

Repository
rP Phabricator
Branch
history1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20289
Build 27543: Run Core Tests
Build 27542: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/diffusion/query/DiffusionCommitQuery.php
320

"is has"

This revision is now accepted and ready to land.May 7 2018, 11:24 PM
This revision was automatically updated to reflect the committed changes.