HomePhabricator

Support an "Ancestors Of: ..." constraint in commit queries

Description

Support an "Ancestors Of: ..." constraint in commit queries

Summary:
Ref T13137. See PHI609. An install would like to filter audit requests on a particular branch, e.g. "master".

This is difficult in the general case because we can not apply this constraint efficiently under every conceivable data shape, but we can do a reasonable job in most practical cases.

See T13137#238822 for more detailed discussion on the approach here.

This is a bit rough, but should do the job for now.

Test Plan:

  • Filtered commits by various branches, e.g. "master"; "lfs". Saw correct-seeming results.
  • Stubbed out the "just list everything" path to hit the diffusion.internal.ancestors path, saw the same correct-seeming results.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13137

Differential Revision: https://secure.phabricator.com/D19431

Details

Provenance
epriestleyAuthored on May 7 2018, 8:38 PM
epriestleyPushed on May 8 2018, 10:51 PM
Reviewer
amckinley
Differential Revision
D19431: Support an "Ancestors Of: ..." constraint in commit queries
Parents
rP397645b2731b: Export task point values as double, not int
Branches
Unknown
Tags
Unknown
Tasks
T13137: Plans: 2018 Week 19 - Week 22 Bonus Content
Build Status
Buildable 20298
Build 27557: Run Core Tests