Page MenuHomePhabricator

Support an "Ancestors Of: ..." constraint in commit queries
ClosedPublic

Authored by epriestley on May 7 2018, 8:50 PM.
Tags
None
Referenced Files
F18993315: D19431.diff
Wed, Nov 19, 7:45 AM
F18864077: D19431.id46481.diff
Mon, Nov 3, 2:44 AM
F18836951: D19431.diff
Mon, Oct 27, 3:59 AM
F18834504: D19431.id46481.diff
Sun, Oct 26, 9:10 AM
F18799235: D19431.id46478.diff
Oct 17 2025, 12:48 PM
F18799234: D19431.id46478.diff
Oct 17 2025, 12:47 PM
F18775542: D19431.id46478.diff
Oct 10 2025, 7:25 PM
F18693446: D19431.diff
Sep 27 2025, 1:09 AM
Subscribers
None

Details

Summary

Ref T13137. See PHI609. An install would like to filter audit requests on a particular branch, e.g. "master".

This is difficult in the general case because we can not apply this constraint efficiently under every conceivable data shape, but we can do a reasonable job in most practical cases.

See T13137#238822 for more detailed discussion on the approach here.

This is a bit rough, but should do the job for now.

Test Plan
  • Filtered commits by various branches, e.g. "master"; "lfs". Saw correct-seeming results.
  • Stubbed out the "just list everything" path to hit the diffusion.internal.ancestors path, saw the same correct-seeming results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/diffusion/query/DiffusionCommitQuery.php
320

"is has"

This revision is now accepted and ready to land.May 7 2018, 11:24 PM
This revision was automatically updated to reflect the committed changes.