Page MenuHomePhabricator

Support an "Ancestors Of: ..." constraint in commit queries
ClosedPublic

Authored by epriestley on May 7 2018, 8:50 PM.
Tags
None
Referenced Files
F15444178: D19431.id46487.diff
Thu, Mar 27, 8:18 AM
F15441932: D19431.id46481.diff
Wed, Mar 26, 8:39 PM
F15440535: D19431.id.diff
Wed, Mar 26, 1:15 PM
F15437048: D19431.diff
Tue, Mar 25, 5:10 PM
F15384727: D19431.id46481.diff
Fri, Mar 14, 8:39 PM
Unknown Object (File)
Thu, Feb 27, 9:24 PM
Unknown Object (File)
Wed, Feb 26, 12:26 PM
Unknown Object (File)
Feb 20 2025, 9:57 PM
Subscribers
None

Details

Summary

Ref T13137. See PHI609. An install would like to filter audit requests on a particular branch, e.g. "master".

This is difficult in the general case because we can not apply this constraint efficiently under every conceivable data shape, but we can do a reasonable job in most practical cases.

See T13137#238822 for more detailed discussion on the approach here.

This is a bit rough, but should do the job for now.

Test Plan
  • Filtered commits by various branches, e.g. "master"; "lfs". Saw correct-seeming results.
  • Stubbed out the "just list everything" path to hit the diffusion.internal.ancestors path, saw the same correct-seeming results.

Diff Detail

Repository
rP Phabricator
Branch
history1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20289
Build 27543: Run Core Tests
Build 27542: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/diffusion/query/DiffusionCommitQuery.php
320

"is has"

This revision is now accepted and ready to land.May 7 2018, 11:24 PM
This revision was automatically updated to reflect the committed changes.