Page MenuHomePhabricator

Support an "Ancestors Of: ..." constraint in commit queries
ClosedPublic

Authored by epriestley on May 7 2018, 8:50 PM.
Tags
None
Referenced Files
F17321559: D19431.id46487.diff
Thu, Jun 26, 9:40 PM
F17319261: D19431.diff
Thu, Jun 26, 6:42 PM
Unknown Object (File)
Thu, May 29, 1:12 PM
Unknown Object (File)
Apr 21 2025, 4:36 AM
Unknown Object (File)
Apr 1 2025, 9:50 PM
Unknown Object (File)
Mar 28 2025, 8:31 PM
Unknown Object (File)
Mar 27 2025, 8:18 AM
Unknown Object (File)
Mar 26 2025, 8:39 PM
Subscribers
None

Details

Summary

Ref T13137. See PHI609. An install would like to filter audit requests on a particular branch, e.g. "master".

This is difficult in the general case because we can not apply this constraint efficiently under every conceivable data shape, but we can do a reasonable job in most practical cases.

See T13137#238822 for more detailed discussion on the approach here.

This is a bit rough, but should do the job for now.

Test Plan
  • Filtered commits by various branches, e.g. "master"; "lfs". Saw correct-seeming results.
  • Stubbed out the "just list everything" path to hit the diffusion.internal.ancestors path, saw the same correct-seeming results.

Diff Detail

Repository
rP Phabricator
Branch
history1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20292
Build 27549: Run Core Tests
Build 27548: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/diffusion/query/DiffusionCommitQuery.php
320

"is has"

This revision is now accepted and ready to land.May 7 2018, 11:24 PM
This revision was automatically updated to reflect the committed changes.