Differential D19348

Make line selection in source code views less fragile and more consistent
ClosedPublic
Actions

Authored by epriestley on Apr 11 2018, 9:15 PM.

Tags

None

Referenced Files

	F15420095: D19348.id46293.diff
	Fri, Mar 21, 11:16 AM

	F15417704: D19348.id46293.diff
	Thu, Mar 20, 5:55 PM

	F15385128: D19348.id46293.diff
	Fri, Mar 14, 9:47 PM

	F15383267: D19348.diff
	Fri, Mar 14, 4:01 PM

	F15332673: D19348.diff
	Fri, Mar 7, 7:02 PM

	Unknown Object (File)
	Sun, Mar 2, 4:57 PM

	Unknown Object (File)
	Fri, Feb 28, 6:05 PM

	Unknown Object (File)
	Jan 29 2025, 7:24 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rPc5c53e277a28: Make line selection in source code views less fragile and more consistent

Summary

Depends on D19347. Ref T13105. See PHI565. The "highlight lines" behavior is interacting poorly with the new blame element in Diffusion.

Make the behavior a little simpler and hopefully more robust.

Test Plan

Clicked commit/revision links in Diffusion, saw the links get followed instead of the lines highlighted.
Highlighted lines in Diffusion, saw just the line/code highlight instead of the whole thing.
Highlighted lines in Paste and new-style Harbormaster build logs, saw consistent behavior.

Diff Detail

Repository

Branch

docu3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20105
Build 27274: Run Core Tests
Build 27273: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 11 2018, 9:15 PM

Harbormaster completed remote builds in B20105: Diff 46286.Apr 11 2018, 9:17 PM

epriestley requested review of this revision.Apr 11 2018, 9:17 PM

epriestley added a child revision: D19349: Use pseudoelements, not Zero Width Space, to implement copy/paste behavior in Paste/Diffusion.Apr 11 2018, 9:30 PM

amckinley accepted this revision.Apr 11 2018, 10:39 PM

This revision is now accepted and ready to land.Apr 11 2018, 10:39 PM

Closed by commit rPc5c53e277a28: Make line selection in source code views less fragile and more consistent (authored by epriestley). · Explain WhyApr 12 2018, 12:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

20 lines

webroot/

rsrc/

css/

layout/

phabricator-source-code-view.css

6 lines

js/

core/

behavior-line-linker.js

34 lines

Diff 46286

resources/celerity/map.php

Loading...

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...

webroot/rsrc/js/core/behavior-line-linker.js

Loading...