Page MenuHomePhabricator

When following a link to a particular line ("/example.txt$12"), scroll to that line

Authored by epriestley on Apr 11 2018, 9:47 PM.



Depends on D19349. Ref T13105. This was the behavior in Diffusion before with a little hard-coded snippet.

Remove that snippet ("diffusion-jump-to") and add a more general-purpose snippet to SourceView.

This is a tiny bit hacky still (and probably doesn't work quite right with Quicksand) but gets things working again and works in all of Files, Paste, and Diffusion.

Test Plan

Followed links to particular lines in Paste, Files and Diffusion; got scrolled to the right place.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 11 2018, 9:47 PM
epriestley requested review of this revision.Apr 11 2018, 9:48 PM
amckinley accepted this revision.Apr 11 2018, 10:41 PM
This revision is now accepted and ready to land.Apr 11 2018, 10:41 PM
This revision was automatically updated to reflect the committed changes.