Page MenuHomePhabricator

Make line selection in source code views less fragile and more consistent
ClosedPublic

Authored by epriestley on Apr 11 2018, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 5:19 PM
Unknown Object (File)
Sun, Mar 10, 12:34 AM
Unknown Object (File)
Fri, Mar 1, 3:53 AM
Unknown Object (File)
Feb 21 2024, 11:44 AM
Unknown Object (File)
Feb 20 2024, 3:01 PM
Unknown Object (File)
Feb 3 2024, 6:45 PM
Unknown Object (File)
Feb 3 2024, 6:45 PM
Unknown Object (File)
Feb 3 2024, 6:45 PM
Subscribers
None

Details

Summary

Depends on D19347. Ref T13105. See PHI565. The "highlight lines" behavior is interacting poorly with the new blame element in Diffusion.

Make the behavior a little simpler and hopefully more robust.

Test Plan
  • Clicked commit/revision links in Diffusion, saw the links get followed instead of the lines highlighted.
  • Highlighted lines in Diffusion, saw just the line/code highlight instead of the whole thing.
  • Highlighted lines in Paste and new-style Harbormaster build logs, saw consistent behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable