Page MenuHomePhabricator

Make line selection in source code views less fragile and more consistent
ClosedPublic

Authored by epriestley on Apr 11 2018, 9:15 PM.
Tags
None
Referenced Files
F18791467: D19348.diff
Thu, Oct 16, 1:49 PM
F18771128: D19348.id46286.diff
Wed, Oct 8, 5:49 PM
F18748600: D19348.id.diff
Fri, Oct 3, 11:38 PM
F18743410: D19348.diff
Thu, Oct 2, 11:33 PM
F18743262: D19348.diff
Thu, Oct 2, 10:59 PM
F18663853: D19348.id.diff
Tue, Sep 23, 10:56 PM
F18509558: D19348.id.diff
Sep 5 2025, 3:28 AM
F18502675: D19348.diff
Sep 4 2025, 10:35 PM
Subscribers
None

Details

Summary

Depends on D19347. Ref T13105. See PHI565. The "highlight lines" behavior is interacting poorly with the new blame element in Diffusion.

Make the behavior a little simpler and hopefully more robust.

Test Plan
  • Clicked commit/revision links in Diffusion, saw the links get followed instead of the lines highlighted.
  • Highlighted lines in Diffusion, saw just the line/code highlight instead of the whole thing.
  • Highlighted lines in Paste and new-style Harbormaster build logs, saw consistent behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable