Page MenuHomePhabricator

Make line selection in source code views less fragile and more consistent
ClosedPublic

Authored by epriestley on Apr 11 2018, 9:15 PM.
Tags
None
Referenced Files
F19810048: D19348.diff
Tue, Mar 3, 5:08 PM
F19798631: D19348.id46293.diff
Fri, Feb 27, 9:48 PM
F19785995: D19348.id.diff
Wed, Feb 25, 4:36 AM
F19612797: D19348.id46293.diff
Feb 3 2026, 7:49 PM
F19513937: D19348.diff
Jan 13 2026, 7:49 PM
F19503567: D19348.diff
Jan 9 2026, 12:21 AM
F18863311: D19348.diff
Nov 2 2025, 10:44 PM
F18791467: D19348.diff
Oct 16 2025, 1:49 PM
Subscribers
None

Details

Summary

Depends on D19347. Ref T13105. See PHI565. The "highlight lines" behavior is interacting poorly with the new blame element in Diffusion.

Make the behavior a little simpler and hopefully more robust.

Test Plan
  • Clicked commit/revision links in Diffusion, saw the links get followed instead of the lines highlighted.
  • Highlighted lines in Diffusion, saw just the line/code highlight instead of the whole thing.
  • Highlighted lines in Paste and new-style Harbormaster build logs, saw consistent behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable