Page MenuHomePhabricator

Make line selection in source code views less fragile and more consistent
ClosedPublic

Authored by epriestley on Apr 11 2018, 9:15 PM.
Tags
None
Referenced Files
F18509558: D19348.id.diff
Fri, Sep 5, 3:28 AM
F18502675: D19348.diff
Thu, Sep 4, 10:35 PM
F18387950: D19348.id46286.diff
Fri, Aug 29, 3:51 AM
F18386504: D19348.id46286.diff
Fri, Aug 29, 2:18 AM
F18385953: D19348.id46293.diff
Fri, Aug 29, 1:49 AM
F18384844: D19348.id.diff
Fri, Aug 29, 12:36 AM
F18097138: D19348.id46293.diff
Aug 8 2025, 11:19 AM
F18095758: D19348.id46286.diff
Aug 8 2025, 2:17 AM
Subscribers
None

Details

Summary

Depends on D19347. Ref T13105. See PHI565. The "highlight lines" behavior is interacting poorly with the new blame element in Diffusion.

Make the behavior a little simpler and hopefully more robust.

Test Plan
  • Clicked commit/revision links in Diffusion, saw the links get followed instead of the lines highlighted.
  • Highlighted lines in Diffusion, saw just the line/code highlight instead of the whole thing.
  • Highlighted lines in Paste and new-style Harbormaster build logs, saw consistent behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable