Page MenuHomePhabricator

Make line selection in source code views less fragile and more consistent
ClosedPublic

Authored by epriestley on Apr 11 2018, 9:15 PM.
Tags
None
Referenced Files
F19905736: D19348.diff
Tue, Mar 31, 7:35 PM
F19905586: D19348.id.diff
Tue, Mar 31, 6:48 PM
F19903166: D19348.diff
Mon, Mar 30, 10:48 PM
F19898227: D19348.id46293.diff
Sun, Mar 29, 11:18 AM
F19891162: D19348.id46286.diff
Thu, Mar 26, 11:52 PM
F19810048: D19348.diff
Mar 3 2026, 5:08 PM
F19798631: D19348.id46293.diff
Feb 27 2026, 9:48 PM
F19785995: D19348.id.diff
Feb 25 2026, 4:36 AM
Subscribers
None

Details

Summary

Depends on D19347. Ref T13105. See PHI565. The "highlight lines" behavior is interacting poorly with the new blame element in Diffusion.

Make the behavior a little simpler and hopefully more robust.

Test Plan
  • Clicked commit/revision links in Diffusion, saw the links get followed instead of the lines highlighted.
  • Highlighted lines in Diffusion, saw just the line/code highlight instead of the whole thing.
  • Highlighted lines in Paste and new-style Harbormaster build logs, saw consistent behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable