Page MenuHomePhabricator

Make line selection in source code views less fragile and more consistent
ClosedPublic

Authored by epriestley on Apr 11 2018, 9:15 PM.
Tags
None
Referenced Files
F14072432: D19348.id46286.diff
Wed, Nov 20, 8:38 PM
Unknown Object (File)
Thu, Nov 14, 7:03 AM
Unknown Object (File)
Fri, Nov 8, 11:47 PM
Unknown Object (File)
Fri, Nov 8, 6:24 AM
Unknown Object (File)
Wed, Oct 30, 8:35 AM
Unknown Object (File)
Sep 25 2024, 10:41 AM
Unknown Object (File)
Sep 25 2024, 8:50 AM
Unknown Object (File)
Sep 24 2024, 7:10 AM
Subscribers
None

Details

Summary

Depends on D19347. Ref T13105. See PHI565. The "highlight lines" behavior is interacting poorly with the new blame element in Diffusion.

Make the behavior a little simpler and hopefully more robust.

Test Plan
  • Clicked commit/revision links in Diffusion, saw the links get followed instead of the lines highlighted.
  • Highlighted lines in Diffusion, saw just the line/code highlight instead of the whole thing.
  • Highlighted lines in Paste and new-style Harbormaster build logs, saw consistent behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable