Page MenuHomePhabricator

Restore an explicit white background color to files in Paste
ClosedPublic

Authored by epriestley on Apr 11 2018, 8:45 PM.
Tags
None
Referenced Files
F15477460: D19346.id46291.diff
Mon, Apr 7, 2:50 PM
F15459721: D19346.id46291.diff
Mon, Mar 31, 3:28 PM
F15446405: D19346.id.diff
Thu, Mar 27, 6:56 PM
F15445917: D19346.id46291.diff
Thu, Mar 27, 4:32 PM
F15439966: D19346.id46284.diff
Wed, Mar 26, 10:34 AM
F15438490: D19346.id.diff
Wed, Mar 26, 1:01 AM
F15433594: D19346.diff
Mon, Mar 24, 11:56 PM
F15416879: D19346.diff
Thu, Mar 20, 2:13 PM
Subscribers
None

Details

Summary

Ref T13105. Previously, the "source code" view in Paste rendered on a brown/orange-ish background. I've been using this element in more contexts (Files, Diffusion) and removed the colored background to make text (particularly syntax-highlighted text) easier to read and reduce visual noise with the new blame colors.

In Diffusion the view is in a box with a white background so removing the background left us with white, but in Paste it's just directly on the page so the background was bleeding through. Instead, set it to white explicitly.

Test Plan

Viewed source files in Files, Diffusion and Paste; saw text on a white background.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable