Page MenuHomePhabricator

Restore an explicit white background color to files in Paste
ClosedPublic

Authored by epriestley on Apr 11 2018, 8:45 PM.

Details

Summary

Ref T13105. Previously, the "source code" view in Paste rendered on a brown/orange-ish background. I've been using this element in more contexts (Files, Diffusion) and removed the colored background to make text (particularly syntax-highlighted text) easier to read and reduce visual noise with the new blame colors.

In Diffusion the view is in a box with a white background so removing the background left us with white, but in Paste it's just directly on the page so the background was bleeding through. Instead, set it to white explicitly.

Test Plan

Viewed source files in Files, Diffusion and Paste; saw text on a white background.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 11 2018, 8:45 PM
epriestley requested review of this revision.Apr 11 2018, 8:46 PM
amckinley accepted this revision.Apr 11 2018, 8:47 PM

Haha I was just wondering if Paste looked like that on purpose 😛

This revision is now accepted and ready to land.Apr 11 2018, 8:47 PM
This revision was automatically updated to reflect the committed changes.