Page MenuHomePhabricator

Restore an explicit white background color to files in Paste
ClosedPublic

Authored by epriestley on Apr 11 2018, 8:45 PM.
Tags
None
Referenced Files
F14143273: D19346.diff
Tue, Dec 3, 3:39 PM
Unknown Object (File)
Tue, Nov 26, 7:53 PM
Unknown Object (File)
Fri, Nov 22, 12:33 PM
Unknown Object (File)
Mon, Nov 18, 1:38 PM
Unknown Object (File)
Thu, Nov 14, 3:35 AM
Unknown Object (File)
Mon, Nov 11, 9:33 AM
Unknown Object (File)
Sun, Nov 10, 4:31 AM
Unknown Object (File)
Wed, Nov 6, 1:40 AM
Subscribers
None

Details

Summary

Ref T13105. Previously, the "source code" view in Paste rendered on a brown/orange-ish background. I've been using this element in more contexts (Files, Diffusion) and removed the colored background to make text (particularly syntax-highlighted text) easier to read and reduce visual noise with the new blame colors.

In Diffusion the view is in a box with a white background so removing the background left us with white, but in Paste it's just directly on the page so the background was bleeding through. Instead, set it to white explicitly.

Test Plan

Viewed source files in Files, Diffusion and Paste; saw text on a white background.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable