Differential D19347

When you make the file tree huge, scroll to the right, and then toggle it, stop it from growing
ClosedPublic
Actions

Authored by epriestley on Apr 11 2018, 8:57 PM.

Tags

None

Referenced Files

	F15563865: D19347.id46292.diff
	Wed, Apr 30, 10:16 AM

	F15547482: D19347.id.diff
	Sat, Apr 26, 7:22 PM

	F15543932: D19347.id46285.diff
	Sat, Apr 26, 1:52 AM

	F15543528: D19347.diff
	Fri, Apr 25, 10:54 PM

	F15503979: D19347.diff
	Mon, Apr 14, 2:50 PM

	F15502507: D19347.diff
	Mon, Apr 14, 1:39 AM

	F15450572: D19347.id46285.diff
	Mar 28 2025, 4:30 PM

	F15443381: D19347.id46285.diff
	Mar 27 2025, 4:08 AM

Subscribers

None

Details

Reviewers

Commits

rPac570fd4bc4e: When you make the file tree huge, scroll to the right, and then toggle it, stop…

Summary

Depends on D19346. Ref PHI568. I love Javascript.

Test Plan

Viewed a revision.
Dragged file tree view really wide.
Scrolled document to the right.
Toggled file tree off and on by pressing "f" twice.
- Before patch: file tree grew wider and wider after it was toggled.
- After patch: file tree stayed the same size after it was toggled.
Dragged to various widths and reloaded to make sure the "sticky across reloads" behavior still works.
Scrolled right, dragged the tree a bit, then reloaded and didn't see it flip out.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 11 2018, 8:57 PM

Harbormaster completed remote builds in B20104: Diff 46285.Apr 11 2018, 8:58 PM

epriestley requested review of this revision.Apr 11 2018, 8:58 PM

epriestley added a child revision: D19348: Make line selection in source code views less fragile and more consistent.Apr 11 2018, 9:15 PM

amckinley accepted this revision.Apr 11 2018, 10:37 PM

This revision is now accepted and ready to land.Apr 11 2018, 10:37 PM

Closed by commit rPac570fd4bc4e: When you make the file tree huge, scroll to the right, and then toggle it, stop… (authored by epriestley). · Explain WhyApr 12 2018, 12:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

26 lines

webroot/

rsrc/

js/

core/

behavior-phabricator-nav.js

15 lines

Diff 46292

resources/celerity/map.php

Loading...

webroot/rsrc/js/core/behavior-phabricator-nav.js

Loading...