Page MenuHomePhabricator

When you make the file tree huge, scroll to the right, and then toggle it, stop it from growing
ClosedPublic

Authored by epriestley on Apr 11 2018, 8:57 PM.
Tags
None
Referenced Files
F17670805: D19347.diff
Sun, Jul 13, 1:32 AM
Unknown Object (File)
Sat, Jun 28, 11:36 PM
Unknown Object (File)
Jun 3 2025, 11:16 AM
Unknown Object (File)
May 31 2025, 10:30 AM
Unknown Object (File)
May 28 2025, 6:11 PM
Unknown Object (File)
May 28 2025, 12:00 AM
Unknown Object (File)
Apr 30 2025, 10:16 AM
Unknown Object (File)
Apr 26 2025, 7:22 PM
Subscribers
None

Details

Summary

Depends on D19346. Ref PHI568. I love Javascript.

Test Plan
  • Viewed a revision.
  • Dragged file tree view really wide.
  • Scrolled document to the right.
  • Toggled file tree off and on by pressing "f" twice.
    • Before patch: file tree grew wider and wider after it was toggled.
    • After patch: file tree stayed the same size after it was toggled.
  • Dragged to various widths and reloaded to make sure the "sticky across reloads" behavior still works.
  • Scrolled right, dragged the tree a bit, then reloaded and didn't see it flip out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable