Page MenuHomePhabricator

Restore an explicit white background color to files in Paste
ClosedPublic

Authored by epriestley on Apr 11 2018, 8:45 PM.
Tags
None
Referenced Files
F13130484: D19346.id46284.diff
Wed, May 1, 9:44 AM
Unknown Object (File)
Thu, Apr 25, 1:54 AM
Unknown Object (File)
Sat, Apr 20, 5:41 AM
Unknown Object (File)
Fri, Apr 19, 7:40 PM
Unknown Object (File)
Fri, Apr 19, 6:34 PM
Unknown Object (File)
Thu, Apr 18, 9:07 AM
Unknown Object (File)
Wed, Apr 17, 6:43 PM
Unknown Object (File)
Wed, Apr 17, 2:53 PM
Subscribers
None

Details

Summary

Ref T13105. Previously, the "source code" view in Paste rendered on a brown/orange-ish background. I've been using this element in more contexts (Files, Diffusion) and removed the colored background to make text (particularly syntax-highlighted text) easier to read and reduce visual noise with the new blame colors.

In Diffusion the view is in a box with a white background so removing the background left us with white, but in Paste it's just directly on the page so the background was bleeding through. Instead, set it to white explicitly.

Test Plan

Viewed source files in Files, Diffusion and Paste; saw text on a white background.

Diff Detail

Repository
rP Phabricator
Branch
docu1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20103
Build 27270: Run Core Tests
Build 27269: arc lint + arc unit