Page MenuHomePhabricator

Restore an explicit white background color to files in Paste
ClosedPublic

Authored by epriestley on Apr 11 2018, 8:45 PM.
Tags
None
Referenced Files
F13044838: D19346.diff
Wed, Apr 17, 6:43 PM
F13043775: D19346.diff
Wed, Apr 17, 2:53 PM
Unknown Object (File)
Sat, Mar 30, 4:24 PM
Unknown Object (File)
Sat, Mar 30, 4:24 PM
Unknown Object (File)
Tue, Mar 26, 5:19 PM
Unknown Object (File)
Mar 1 2024, 3:53 AM
Unknown Object (File)
Feb 21 2024, 11:43 AM
Unknown Object (File)
Feb 20 2024, 9:12 PM
Subscribers
None

Details

Summary

Ref T13105. Previously, the "source code" view in Paste rendered on a brown/orange-ish background. I've been using this element in more contexts (Files, Diffusion) and removed the colored background to make text (particularly syntax-highlighted text) easier to read and reduce visual noise with the new blame colors.

In Diffusion the view is in a box with a white background so removing the background left us with white, but in Paste it's just directly on the page so the background was bleeding through. Instead, set it to white explicitly.

Test Plan

Viewed source files in Files, Diffusion and Paste; saw text on a white background.

Diff Detail

Repository
rP Phabricator
Branch
docu1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20103
Build 27270: Run Core Tests
Build 27269: arc lint + arc unit