Paths

Table of Contentst

Differential D19311

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly
ClosedPublic
Actions

Authored by epriestley on Apr 9 2018, 12:20 PM.

Tags

None

Referenced Files

	F15513136: D19311.diff
	Thu, Apr 17, 4:35 PM

	F15491949: D19311.id46214.diff
	Sat, Apr 12, 9:16 AM

	F15459007: D19311.id46209.diff
	Mon, Mar 31, 9:05 AM

	F15453032: D19311.id46209.diff
	Sat, Mar 29, 8:54 AM

	F15449215: D19311.id46214.diff
	Fri, Mar 28, 8:56 AM

	F15447644: D19311.id.diff
	Fri, Mar 28, 12:44 AM

	F15442843: D19311.diff
	Thu, Mar 27, 12:50 AM

	F15423234: D19311.diff
	Mar 22 2025, 2:09 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits: rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly

Summary

Depends on D19310. Ref T13105. The "meta" value was not populating correctly because this used phutil_tag().

Test Plan

Will verify on secure.

Diff Detail

Repository

rP Phabricator

Branch

dfile10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20033
Build 27166: Run Core Tests
Build 27165: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 9 2018, 12:20 PM

Harbormaster completed remote builds in B20033: Diff 46209.Apr 9 2018, 12:21 PM

epriestley requested review of this revision.Apr 9 2018, 12:21 PM

epriestley added a child revision: D19312: When you swap between document rendering engines, populate or redraw blame if appropriate.Apr 9 2018, 12:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2018, 1:10 PM

Closed by commit rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBlameController.php

11 lines

Diff 46209

View Options

src/applications/diffusion/controller/DiffusionBlameController.php

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properlyClosedPublicActions