Paths

Table of Contentst

Differential D19311

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly
ClosedPublic
Actions

Authored by epriestley on Apr 9 2018, 12:20 PM.

Tags

None

Referenced Files

	F19079754: D19311.id.diff
	Dec 1 2025, 10:37 PM

	F19072673: D19311.diff
	Nov 30 2025, 11:09 PM

	F19050832: D19311.id.diff
	Nov 27 2025, 10:06 PM

	F19032222: D19311.diff
	Nov 25 2025, 5:09 AM

	F19015312: D19311.id46209.diff
	Nov 22 2025, 11:48 PM

	F19015310: D19311.id46214.diff
	Nov 22 2025, 11:48 PM

	F19015309: D19311.id.diff
	Nov 22 2025, 11:48 PM

	F19014741: D19311.diff
	Nov 22 2025, 9:35 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits: rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly

Summary

Depends on D19310. Ref T13105. The "meta" value was not populating correctly because this used phutil_tag().

Test Plan

Will verify on secure.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 9 2018, 12:20 PM

Harbormaster completed remote builds in B20033: Diff 46209.Apr 9 2018, 12:21 PM

epriestley requested review of this revision.Apr 9 2018, 12:21 PM

epriestley added a child revision: D19312: When you swap between document rendering engines, populate or redraw blame if appropriate.Apr 9 2018, 12:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2018, 1:10 PM

Closed by commit rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBlameController.php

11 lines

Diff 46214

View Options

src/applications/diffusion/controller/DiffusionBlameController.php

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properlyClosedPublicActions