Paths

Table of Contentst

Differential D19311

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly
ClosedPublic
Actions

Authored by epriestley on Apr 9 2018, 12:20 PM.

Tags

None

Referenced Files

	F18813707: D19311.id46214.diff
	Mon, Oct 20, 6:41 PM

	F18777977: D19311.id46209.diff
	Sat, Oct 11, 7:02 AM

	F18733283: D19311.id.diff
	Tue, Sep 30, 10:23 PM

	F18717516: D19311.diff
	Mon, Sep 29, 2:04 PM

	F18652926: D19311.diff
	Sep 21 2025, 10:15 AM

	F18652895: D19311.diff
	Sep 21 2025, 10:04 AM

	F18571317: D19311.diff
	Sep 10 2025, 4:55 AM

	F18509525: D19311.id.diff
	Sep 5 2025, 3:27 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits: rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly

Summary

Depends on D19310. Ref T13105. The "meta" value was not populating correctly because this used phutil_tag().

Test Plan

Will verify on secure.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 9 2018, 12:20 PM

Harbormaster completed remote builds in B20033: Diff 46209.Apr 9 2018, 12:21 PM

epriestley requested review of this revision.Apr 9 2018, 12:21 PM

epriestley added a child revision: D19312: When you swap between document rendering engines, populate or redraw blame if appropriate.Apr 9 2018, 12:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2018, 1:10 PM

Closed by commit rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBlameController.php

11 lines

Diff 46214

View Options

src/applications/diffusion/controller/DiffusionBlameController.php

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properlyClosedPublicActions