Differential D19310

Make DocumentEngine source line linking behavior better when blame is shown
ClosedPublic
Actions

Authored by epriestley on Apr 9 2018, 12:16 PM.

Tags

None

Referenced Files

	F17951004: D19310.id46213.diff
	Fri, Aug 1, 12:56 AM

	F17917146: D19310.diff
	Tue, Jul 29, 11:13 PM

	F17703958: D19310.id46213.diff
	Wed, Jul 16, 2:52 AM

	Unknown Object (File)
	Jun 3 2025, 8:29 PM

	Unknown Object (File)
	Jun 2 2025, 1:31 PM

	Unknown Object (File)
	Jun 1 2025, 12:20 PM

	Unknown Object (File)
	May 30 2025, 10:47 AM

	Unknown Object (File)
	May 6 2025, 4:56 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits: rP11664277b33d: Make DocumentEngine source line linking behavior better when blame is shown

Summary

Ref T13105. The line linker behavior currently has trouble identifying the line number when blame is active. Improve this, albeit not the most cleanly.

Test Plan

Selected lines with blame on.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 9 2018, 12:16 PM

Harbormaster completed remote builds in B20032: Diff 46208.Apr 9 2018, 12:17 PM

epriestley requested review of this revision.Apr 9 2018, 12:17 PM

epriestley added a child revision: D19311: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly.Apr 9 2018, 12:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2018, 1:09 PM

Closed by commit rP11664277b33d: Make DocumentEngine source line linking behavior better when blame is shown (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

16 lines

webroot/

rsrc/

js/

core/

behavior-line-linker.js

17 lines

Diff 46213

View Options

resources/celerity/map.php