Make DocumentEngine source line linking behavior better when blame is shown
11664277b33d
Actions

Description

Make DocumentEngine source line linking behavior better when blame is shown

Summary: Ref T13105. The line linker behavior currently has trouble identifying the line number when blame is active. Improve this, albeit not the most cleanly.

Test Plan: Selected lines with blame on.

Maniphest Tasks: T13105

Differential Revision: https://secure.phabricator.com/D19310

Details

Provenance

epriestley	Authored on Apr 9 2018, 12:08 PM
epriestley	Pushed on Apr 9 2018, 1:09 PM

Differential Revision

D19310: Make DocumentEngine source line linking behavior better when blame is shown

Parents

rP09c6d42b9599: Mostly make blame work with DocumentEngine

Branches

Unknown

Tags

Unknown

Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Build Status

Buildable 20037
Build 27173: Run Core Tests

Event Timeline

epriestley committed rP11664277b33d: Make DocumentEngine source line linking behavior better when blame is shown (authored by epriestley).Apr 9 2018, 1:09 PM

epriestley added a task: T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Harbormaster completed building B20037: rP11664277b33d: Make DocumentEngine source line linking behavior better when blame is shown.Apr 9 2018, 1:11 PM

Changes (2)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

core/

behavior-line-linker.js

rP11664277b33d

View Options

resources/celerity/map.php