Paths

Table of Contentst

Diffusion Phabricator eca7dc25f20b

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly
eca7dc25f20b
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly

Summary: Depends on D19310. Ref T13105. The "meta" value was not populating correctly because this used phutil_tag().

Test Plan: Will verify on secure.

Maniphest Tasks: T13105

Differential Revision: https://secure.phabricator.com/D19311

Details

Provenance

epriestley	Authored on Apr 9 2018, 12:18 PM
epriestley	Pushed on Apr 9 2018, 1:10 PM

Differential Revision

D19311: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly

Parents

rP11664277b33d: Make DocumentEngine source line linking behavior better when blame is shown

Branches

Unknown

Tags

Unknown

Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Build Status

Buildable 20038
Build 27174: Run Core Tests

Event Timeline

epriestley committed rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly (authored by epriestley).Apr 9 2018, 1:10 PM

epriestley added a task: T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Harbormaster failed to build B20038: rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly!Apr 9 2018, 1:13 PM

Harbormaster completed building B20038: rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly.Apr 9 2018, 1:22 PM

Changes (1)

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBlameController.php

rPeca7dc25f20b

src/applications/diffusion/controller/DiffusionBlameController.php

Loading...