Differential D19312

When you swap between document rendering engines, populate or redraw blame if appropriate
ClosedPublic
Actions

Authored by epriestley on Apr 9 2018, 12:26 PM.

Details

Reviewers: None
Maniphest Tasks: T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits: rPeb80f0a2d95d: When you swap between document rendering engines, populate or redraw blame if…

Summary

Depends on D19311. Ref T13105. Currently, blame only renders on the initial request. Instead, redraw blame after swapping views.

Test Plan

Swapped from "Source -> Hexdump -> Source" and "Hexdump -> Source". Saw blame on source in all cases.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 9 2018, 12:26 PM

Harbormaster completed remote builds in B20034: Diff 46210.Apr 9 2018, 12:28 PM

epriestley requested review of this revision.Apr 9 2018, 12:28 PM

epriestley added a child revision: D19313: When lines 12, 13, 14, etc all blame to the same change, only show it once.Apr 9 2018, 12:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2018, 1:10 PM

Closed by commit rPeb80f0a2d95d: When you swap between document rendering engines, populate or redraw blame if… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

webroot/

rsrc/

js/

application/

files/

behavior-document-engine.js

24 lines

Diff 46215

View Options

resources/celerity/map.php