Paths

Table of Contentst

Differential D19311

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly
ClosedPublic
Actions

Authored by epriestley on Apr 9 2018, 12:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sep 16 2024, 12:06 AM

	Unknown Object (File)
	Sep 14 2024, 5:07 AM

	Unknown Object (File)
	Sep 9 2024, 3:01 PM

	Unknown Object (File)
	Sep 3 2024, 2:49 PM

	Unknown Object (File)
	Sep 1 2024, 8:34 PM

	Unknown Object (File)
	Aug 25 2024, 11:49 AM

	Unknown Object (File)
	Aug 20 2024, 7:11 PM

	Unknown Object (File)
	Aug 16 2024, 4:05 AM

View All 98 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits: rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly

Summary

Depends on D19310. Ref T13105. The "meta" value was not populating correctly because this used phutil_tag().

Test Plan

Will verify on secure.

Diff Detail

Repository

Branch

dfile10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20033
Build 27166: Run Core Tests
Build 27165: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 9 2018, 12:20 PM

Harbormaster completed remote builds in B20033: Diff 46209.Apr 9 2018, 12:21 PM

epriestley requested review of this revision.Apr 9 2018, 12:21 PM

epriestley added a child revision: D19312: When you swap between document rendering engines, populate or redraw blame if appropriate.Apr 9 2018, 12:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2018, 1:10 PM

Closed by commit rPeca7dc25f20b: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBlameController.php

11 lines

Diff 46209

src/applications/diffusion/controller/DiffusionBlameController.php

Loading...