Page MenuHomePhabricator

Start buildables in "PREPARING", move them to "BUILDING" after builds queue
ClosedPublic

Authored by epriestley on Feb 12 2018, 7:54 PM.
Tags
None
Referenced Files
F19822486: D19065.id45701.diff
Sat, Mar 7, 5:53 AM
F19660932: D19065.diff
Feb 7 2026, 5:06 AM
F19136885: D19065.id45706.diff
Dec 10 2025, 9:55 AM
F19086467: D19065.id.diff
Dec 2 2025, 9:32 PM
F19080070: D19065.diff
Dec 1 2025, 11:57 PM
F18913298: D19065.id45706.diff
Nov 9 2025, 5:43 AM
F18885605: D19065.id.diff
Nov 7 2025, 3:30 AM
F18871919: D19065.id.diff
Nov 5 2025, 1:22 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19064. Ref T13054. See that task for additional discussion.

When buildables are created by arc and have lint/unit messages, they can currently pass or fail before Herald triggers actual builds. This puts them in a pre-build state where they can't complete until Herald says it's okay.

On its own, this change intentionally strands arc diff --only diffs in the "PREPARING" stage forever.

Test Plan
  • Ran a build with bin/harbormaster, saw it build normally.
  • Ran a build with web UI, saw it build normally.
  • Ran a build with arc diff, saw it build normally.
  • Ran a build with arc diff --only, saw it hang in "PREPARING" forever.

Diff Detail

Repository
rP Phabricator
Branch
hrace4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19504
Build 26390: Run Core Tests
Build 26389: arc lint + arc unit