Page MenuHomePhabricator

Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
ClosedPublic

Authored by epriestley on Feb 12 2018, 8:11 PM.
Tags
None
Referenced Files
F19093611: D19066.id.diff
Dec 3 2025, 9:56 PM
F19076656: D19066.diff
Dec 1 2025, 12:50 PM
F19070111: D19066.id45702.diff
Nov 30 2025, 3:43 PM
F19059513: D19066.id45702.diff
Nov 29 2025, 5:32 AM
F18941119: D19066.diff
Nov 11 2025, 9:35 AM
F18863214: D19066.id.diff
Nov 2 2025, 10:23 PM
F18852811: D19066.diff
Oct 31 2025, 12:13 PM
F18839673: D19066.diff
Oct 27 2025, 6:10 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19065. Ref T13054. Instead of just updating containerPHID and hoping for the best, queue a proper BuildWorker to process a "your container has changed, update it" message.

We also need to remove a (superfluous) withContainerPHIDs() when loading active diffs for a revision.

Test Plan
  • Without daemons, created a revision and saw builds stick in "preparing" with no container PHID, but also stay in draft mode.
  • With daemons, saw builds actually build and get the right container PHID.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 12 2018, 8:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.