Page MenuHomePhabricator

Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
ClosedPublic

Authored by epriestley on Feb 12 2018, 8:11 PM.
Tags
None
Referenced Files
F13360382: D19066.diff
Tue, Jun 25, 11:17 AM
F13356809: D19066.diff
Mon, Jun 24, 9:06 PM
F13345398: D19066.diff
Fri, Jun 21, 10:25 AM
F13342008: D19066.id.diff
Thu, Jun 20, 9:52 AM
F13312931: D19066.diff
Tue, Jun 11, 7:19 AM
F13299493: D19066.diff
Fri, Jun 7, 8:04 AM
F13268726: D19066.diff
Wed, May 29, 5:19 AM
F13254296: D19066.diff
May 25 2024, 3:18 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19065. Ref T13054. Instead of just updating containerPHID and hoping for the best, queue a proper BuildWorker to process a "your container has changed, update it" message.

We also need to remove a (superfluous) withContainerPHIDs() when loading active diffs for a revision.

Test Plan
  • Without daemons, created a revision and saw builds stick in "preparing" with no container PHID, but also stay in draft mode.
  • With daemons, saw builds actually build and get the right container PHID.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 12 2018, 8:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.