Page MenuHomePhabricator

Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
ClosedPublic

Authored by epriestley on Feb 12 2018, 8:11 PM.
Tags
None
Referenced Files
F18739790: D19066.id.diff
Wed, Oct 1, 10:58 PM
F18672902: D19066.id45707.diff
Thu, Sep 25, 8:35 AM
F18619478: D19066.diff
Sep 15 2025, 2:33 AM
F18509302: D19066.id.diff
Sep 5 2025, 3:20 AM
F18502137: D19066.diff
Sep 4 2025, 10:13 PM
F18446630: D19066.id.diff
Aug 31 2025, 10:03 PM
F18417448: D19066.diff
Aug 30 2025, 11:45 AM
F18392679: D19066.diff
Aug 29 2025, 8:29 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19065. Ref T13054. Instead of just updating containerPHID and hoping for the best, queue a proper BuildWorker to process a "your container has changed, update it" message.

We also need to remove a (superfluous) withContainerPHIDs() when loading active diffs for a revision.

Test Plan
  • Without daemons, created a revision and saw builds stick in "preparing" with no container PHID, but also stay in draft mode.
  • With daemons, saw builds actually build and get the right container PHID.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 12 2018, 8:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.