Page MenuHomePhabricator

Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
ClosedPublic

Authored by epriestley on Feb 12 2018, 8:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 19 2026, 3:27 AM
Unknown Object (File)
Mar 17 2026, 9:17 PM
Unknown Object (File)
Feb 28 2026, 4:37 PM
Unknown Object (File)
Dec 3 2025, 9:56 PM
Unknown Object (File)
Dec 1 2025, 12:50 PM
Unknown Object (File)
Nov 30 2025, 3:43 PM
Unknown Object (File)
Nov 29 2025, 5:32 AM
Unknown Object (File)
Nov 11 2025, 9:35 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19065. Ref T13054. Instead of just updating containerPHID and hoping for the best, queue a proper BuildWorker to process a "your container has changed, update it" message.

We also need to remove a (superfluous) withContainerPHIDs() when loading active diffs for a revision.

Test Plan
  • Without daemons, created a revision and saw builds stick in "preparing" with no container PHID, but also stay in draft mode.
  • With daemons, saw builds actually build and get the right container PHID.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 12 2018, 8:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.