Page MenuHomePhabricator

Start buildables in "PREPARING", move them to "BUILDING" after builds queue
ClosedPublic

Authored by epriestley on Feb 12 2018, 7:54 PM.
Tags
None
Referenced Files
F18913298: D19065.id45706.diff
Sun, Nov 9, 5:43 AM
F18885605: D19065.id.diff
Fri, Nov 7, 3:30 AM
F18871919: D19065.id.diff
Wed, Nov 5, 1:22 AM
F18871755: D19065.id45701.diff
Wed, Nov 5, 12:27 AM
F18868968: D19065.diff
Tue, Nov 4, 9:27 AM
F18854375: D19065.diff
Fri, Oct 31, 11:45 PM
F18795750: D19065.id45706.diff
Oct 17 2025, 2:25 AM
F18761161: D19065.diff
Oct 6 2025, 12:39 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19064. Ref T13054. See that task for additional discussion.

When buildables are created by arc and have lint/unit messages, they can currently pass or fail before Herald triggers actual builds. This puts them in a pre-build state where they can't complete until Herald says it's okay.

On its own, this change intentionally strands arc diff --only diffs in the "PREPARING" stage forever.

Test Plan
  • Ran a build with bin/harbormaster, saw it build normally.
  • Ran a build with web UI, saw it build normally.
  • Ran a build with arc diff, saw it build normally.
  • Ran a build with arc diff --only, saw it hang in "PREPARING" forever.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable