Page MenuHomePhabricator

Start buildables in "PREPARING", move them to "BUILDING" after builds queue
ClosedPublic

Authored by epriestley on Feb 12 2018, 7:54 PM.
Tags
None
Referenced Files
F15531883: D19065.id45701.diff
Wed, Apr 23, 1:36 PM
F15530706: D19065.id45706.diff
Wed, Apr 23, 7:00 AM
F15529483: D19065.id.diff
Tue, Apr 22, 8:09 PM
F15465928: D19065.id45701.diff
Thu, Apr 3, 12:19 AM
F15441303: D19065.id45706.diff
Wed, Mar 26, 5:25 PM
F15391055: D19065.id45706.diff
Mar 15 2025, 8:00 AM
F15385108: D19065.id45701.diff
Mar 14 2025, 9:43 PM
F15371181: D19065.id45706.diff
Mar 12 2025, 11:30 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19064. Ref T13054. See that task for additional discussion.

When buildables are created by arc and have lint/unit messages, they can currently pass or fail before Herald triggers actual builds. This puts them in a pre-build state where they can't complete until Herald says it's okay.

On its own, this change intentionally strands arc diff --only diffs in the "PREPARING" stage forever.

Test Plan
  • Ran a build with bin/harbormaster, saw it build normally.
  • Ran a build with web UI, saw it build normally.
  • Ran a build with arc diff, saw it build normally.
  • Ran a build with arc diff --only, saw it hang in "PREPARING" forever.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable