Page MenuHomePhabricator

Start buildables in "PREPARING", move them to "BUILDING" after builds queue
ClosedPublic

Authored by epriestley on Feb 12 2018, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:08 AM
Unknown Object (File)
Fri, Apr 19, 7:20 PM
Unknown Object (File)
Wed, Apr 17, 2:54 PM
Unknown Object (File)
Thu, Apr 11, 3:30 PM
Unknown Object (File)
Sat, Mar 30, 6:46 PM
Unknown Object (File)
Sat, Mar 30, 6:46 PM
Unknown Object (File)
Sat, Mar 30, 6:46 PM
Unknown Object (File)
Sat, Mar 30, 9:26 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19064. Ref T13054. See that task for additional discussion.

When buildables are created by arc and have lint/unit messages, they can currently pass or fail before Herald triggers actual builds. This puts them in a pre-build state where they can't complete until Herald says it's okay.

On its own, this change intentionally strands arc diff --only diffs in the "PREPARING" stage forever.

Test Plan
  • Ran a build with bin/harbormaster, saw it build normally.
  • Ran a build with web UI, saw it build normally.
  • Ran a build with arc diff, saw it build normally.
  • Ran a build with arc diff --only, saw it hang in "PREPARING" forever.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable