Page MenuHomePhabricator

Start buildables in "PREPARING", move them to "BUILDING" after builds queue
ClosedPublic

Authored by epriestley on Feb 12 2018, 7:54 PM.
Tags
None
Referenced Files
F18372744: D19065.diff
Thu, Aug 28, 6:47 AM
F18099675: D19065.id45706.diff
Sat, Aug 9, 7:33 AM
F18081728: D19065.id45701.diff
Tue, Aug 5, 1:45 AM
F17949459: D19065.id.diff
Thu, Jul 31, 11:28 PM
F17941223: D19065.diff
Thu, Jul 31, 5:08 AM
F17940265: D19065.id45706.diff
Thu, Jul 31, 4:10 AM
F17937077: D19065.diff
Thu, Jul 31, 12:49 AM
F17816109: D19065.id.diff
Jul 25 2025, 10:32 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19064. Ref T13054. See that task for additional discussion.

When buildables are created by arc and have lint/unit messages, they can currently pass or fail before Herald triggers actual builds. This puts them in a pre-build state where they can't complete until Herald says it's okay.

On its own, this change intentionally strands arc diff --only diffs in the "PREPARING" stage forever.

Test Plan
  • Ran a build with bin/harbormaster, saw it build normally.
  • Ran a build with web UI, saw it build normally.
  • Ran a build with arc diff, saw it build normally.
  • Ran a build with arc diff --only, saw it hang in "PREPARING" forever.

Diff Detail

Repository
rP Phabricator
Branch
hrace4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19504
Build 26390: Run Core Tests
Build 26389: arc lint + arc unit