Paths

Table of Contentst

Differential D19064

Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements
ClosedPublic
Actions

Authored by epriestley on Feb 12 2018, 7:09 PM.

Details

Reviewers: None
Maniphest Tasks: T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction
Commits: rPf939a2b12ea3: Make Harbormaster buildable status more of a nice flexible map and less of a…

Summary

Depends on D19063. Ref T13054. Prepare for the addition of a new PREPARING status by getting rid of the "scattered mess of switch statements" pattern of status management.

Test Plan

Searched/browsed buildables. Viewed buildables. Viewed revisions. Grepped for all affected symbols.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2018, 7:09 PM

Owners added a subscriber: Restricted Owners Package.Feb 12 2018, 7:09 PM

Harbormaster completed remote builds in B19503: Diff 45700.Feb 12 2018, 7:10 PM

epriestley requested review of this revision.Feb 12 2018, 7:11 PM

epriestley added a child revision: D19065: Start buildables in "PREPARING", move them to "BUILDING" after builds queue.Feb 12 2018, 7:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 8:18 PM

Closed by commit rPf939a2b12ea3: Make Harbormaster buildable status more of a nice flexible map and less of a… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

differential/

customfield/

DifferentialUnitField.php

4 lines

diffusion/

view/

DiffusionView.php

7 lines

harbormaster/

conduit/

HarbormasterQueryBuildablesConduitAPIMethod.php

2 lines

constants/

HarbormasterBuildableStatus.php

82 lines

engine/

HarbormasterBuildEngine.php

13 lines

event/

HarbormasterUIEventListener.php

10 lines

query/

HarbormasterBuildableSearchEngine.php

10 lines

storage/

HarbormasterBuildable.php

78 lines

transactions/

storage/

PhabricatorApplicationTransaction.php

14 lines

Diff 45705

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/customfield/DifferentialUnitField.php

View Options

src/applications/diffusion/view/DiffusionView.php

View Options

src/applications/harbormaster/conduit/HarbormasterQueryBuildablesConduitAPIMethod.php

View Options

src/applications/harbormaster/constants/HarbormasterBuildableStatus.php

View Options

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

View Options

src/applications/harbormaster/event/HarbormasterUIEventListener.php

View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statementsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45705

src/__phutil_library_map__.php

src/applications/differential/customfield/DifferentialUnitField.php

src/applications/diffusion/view/DiffusionView.php

src/applications/harbormaster/conduit/HarbormasterQueryBuildablesConduitAPIMethod.php

src/applications/harbormaster/constants/HarbormasterBuildableStatus.php

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

src/applications/harbormaster/event/HarbormasterUIEventListener.php

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

src/applications/harbormaster/storage/HarbormasterBuildable.php

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements
ClosedPublic
Actions

Revision Contents
Changeset List