Page MenuHomePhabricator

Remove a very old Herald garbage collection migration
ClosedPublic

Authored by epriestley on Jan 25 2018, 3:28 AM.
Tags
None
Referenced Files
F19512332: D18924.id45419.diff
Mon, Jan 12, 4:57 PM
F19512262: D18924.id45419.diff
Mon, Jan 12, 3:21 PM
F19289341: D18924.id45419.diff
Tue, Dec 23, 8:20 AM
F19052337: D18924.id45419.diff
Nov 28 2025, 4:36 AM
F19052336: D18924.id45392.diff
Nov 28 2025, 4:36 AM
F19052317: D18924.id.diff
Nov 28 2025, 4:31 AM
F19052259: D18924.diff
Nov 28 2025, 4:22 AM
F18993907: D18924.id.diff
Nov 19 2025, 9:24 AM
Subscribers
None

Details

Summary

Ref T13048. This migration is from January 2012 and probably only impacted Facebook.

It references HeraldRepetitionPolicyConfig, which I'd like to change significantly. I initially just replaced the constant with a literal 0, but I don't think there's any actual value in retaining this migration nowadays.

The cost of removing this migration is: if you installed Phabricator before January 2012 and haven't upgraded since then, you'll have a few more rows in the APPLIED table than necessary. Herald will still work correctly.

Test Plan

Reading.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable