Page MenuHomePhabricator

Remove a very old Herald garbage collection migration
ClosedPublic

Authored by epriestley on Jan 25 2018, 3:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 5:02 AM
Unknown Object (File)
Sun, Feb 9, 5:02 AM
Unknown Object (File)
Sun, Feb 9, 5:02 AM
Unknown Object (File)
Jan 27 2025, 2:29 AM
Unknown Object (File)
Jan 24 2025, 11:14 PM
Unknown Object (File)
Jan 24 2025, 11:14 PM
Unknown Object (File)
Jan 24 2025, 11:14 PM
Unknown Object (File)
Jan 24 2025, 7:00 PM
Subscribers
None

Details

Summary

Ref T13048. This migration is from January 2012 and probably only impacted Facebook.

It references HeraldRepetitionPolicyConfig, which I'd like to change significantly. I initially just replaced the constant with a literal 0, but I don't think there's any actual value in retaining this migration nowadays.

The cost of removing this migration is: if you installed Phabricator before January 2012 and haven't upgraded since then, you'll have a few more rows in the APPLIED table than necessary. Herald will still work correctly.

Test Plan

Reading.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19173
Build 25889: Run Core Tests
Build 25888: arc lint + arc unit