Page MenuHomePhabricator

Explicitly decline to add commit authors as auditors from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 16, 9:42 AM
Unknown Object (File)
Thu, Sep 5, 11:05 PM
Unknown Object (File)
Sat, Aug 31, 2:42 AM
Unknown Object (File)
Fri, Aug 30, 7:38 PM
Unknown Object (File)
Fri, Aug 30, 12:27 AM
Unknown Object (File)
Aug 17 2024, 7:30 PM
Unknown Object (File)
Aug 16 2024, 12:36 AM
Unknown Object (File)
Aug 12 2024, 11:23 AM
Subscribers
None

Details

Summary

Fixes T12304. If you have a Herald rule which tries to add a commit author as an auditor, it fails validation when trying to apply.

Stop trying to apply these transactions, and explicitly tell the user why. Differential already uses a similar ruleset around reviewers, but Audit was using older code.

Test Plan
  • Wrote a Herald rule to add A, B and C as auditors.
  • Committed as A.
  • After change, saw B and C added with transacript guidance that A was the author.

Screen Shot 2017-02-23 at 2.42.02 PM.png (201×540 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Branch
audit2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15747
Build 20811: Run Core Tests
Build 20810: arc lint + arc unit