Page MenuHomePhabricator

Explicitly decline to add commit authors as auditors from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:47 PM.
Tags
None
Referenced Files
F14040693: D17404.id41850.diff
Mon, Nov 11, 12:27 PM
F13983332: D17404.id41850.diff
Sun, Oct 20, 5:44 AM
Unknown Object (File)
Oct 3 2024, 1:06 AM
Unknown Object (File)
Sep 28 2024, 3:29 PM
Unknown Object (File)
Sep 23 2024, 8:23 PM
Unknown Object (File)
Sep 16 2024, 9:42 AM
Unknown Object (File)
Sep 5 2024, 11:05 PM
Unknown Object (File)
Aug 31 2024, 2:42 AM
Subscribers
None

Details

Summary

Fixes T12304. If you have a Herald rule which tries to add a commit author as an auditor, it fails validation when trying to apply.

Stop trying to apply these transactions, and explicitly tell the user why. Differential already uses a similar ruleset around reviewers, but Audit was using older code.

Test Plan
  • Wrote a Herald rule to add A, B and C as auditors.
  • Committed as A.
  • After change, saw B and C added with transacript guidance that A was the author.

Screen Shot 2017-02-23 at 2.42.02 PM.png (201×540 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable