Page MenuHomePhabricator

Explicitly decline to add commit authors as auditors from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:47 PM.
Tags
None
Referenced Files
F19059382: D17404.id.diff
Sat, Nov 29, 5:15 AM
F19053095: D17404.diff
Fri, Nov 28, 7:18 AM
F18843127: D17404.diff
Oct 28 2025, 9:03 PM
F18840956: D17404.id.diff
Oct 28 2025, 5:30 AM
F18837743: D17404.diff
Oct 27 2025, 7:32 AM
F18828583: D17404.id.diff
Oct 24 2025, 5:11 PM
F18682256: D17404.id.diff
Sep 26 2025, 5:30 AM
F18672316: D17404.diff
Sep 25 2025, 7:16 AM
Subscribers
None

Details

Summary

Fixes T12304. If you have a Herald rule which tries to add a commit author as an auditor, it fails validation when trying to apply.

Stop trying to apply these transactions, and explicitly tell the user why. Differential already uses a similar ruleset around reviewers, but Audit was using older code.

Test Plan
  • Wrote a Herald rule to add A, B and C as auditors.
  • Committed as A.
  • After change, saw B and C added with transacript guidance that A was the author.

Screen Shot 2017-02-23 at 2.42.02 PM.png (201×540 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable