Page MenuHomePhabricator

Explicitly decline to add commit authors as auditors from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:47 PM.
Tags
None
Referenced Files
F13241381: D17404.id41852.diff
Wed, May 22, 8:45 PM
F13222806: D17404.diff
Sun, May 19, 3:59 AM
F13208211: D17404.id.diff
Thu, May 16, 11:33 AM
F13202582: D17404.diff
Tue, May 14, 10:52 PM
Unknown Object (File)
Tue, May 7, 5:00 AM
Unknown Object (File)
Sun, May 5, 11:04 PM
Unknown Object (File)
Thu, Apr 25, 2:46 AM
Unknown Object (File)
Apr 11 2024, 10:03 AM
Subscribers
None

Details

Summary

Fixes T12304. If you have a Herald rule which tries to add a commit author as an auditor, it fails validation when trying to apply.

Stop trying to apply these transactions, and explicitly tell the user why. Differential already uses a similar ruleset around reviewers, but Audit was using older code.

Test Plan
  • Wrote a Herald rule to add A, B and C as auditors.
  • Committed as A.
  • After change, saw B and C added with transacript guidance that A was the author.

Screen Shot 2017-02-23 at 2.42.02 PM.png (201×540 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Branch
audit2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15747
Build 20811: Run Core Tests
Build 20810: arc lint + arc unit