Page MenuHomePhabricator

Explicitly decline to add commit authors as auditors from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:47 PM.
Tags
None
Referenced Files
F15408218: D17404.id41852.diff
Tue, Mar 18, 9:42 PM
F15394029: D17404.id41850.diff
Sat, Mar 15, 11:19 PM
F15377729: D17404.diff
Thu, Mar 13, 10:29 AM
F15374813: D17404.id41850.diff
Wed, Mar 12, 8:18 PM
F15335376: D17404.id41850.diff
Sat, Mar 8, 3:07 PM
Unknown Object (File)
Fri, Feb 28, 8:40 PM
Unknown Object (File)
Feb 9 2025, 3:21 AM
Unknown Object (File)
Feb 9 2025, 3:21 AM
Subscribers
None

Details

Summary

Fixes T12304. If you have a Herald rule which tries to add a commit author as an auditor, it fails validation when trying to apply.

Stop trying to apply these transactions, and explicitly tell the user why. Differential already uses a similar ruleset around reviewers, but Audit was using older code.

Test Plan
  • Wrote a Herald rule to add A, B and C as auditors.
  • Committed as A.
  • After change, saw B and C added with transacript guidance that A was the author.

Screen Shot 2017-02-23 at 2.42.02 PM.png (201×540 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Branch
audit2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15747
Build 20811: Run Core Tests
Build 20810: arc lint + arc unit