Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks"
ClosedPublic
Actions

Authored by epriestley on Jun 22 2016, 5:36 PM.

Details

Reviewers

Maniphest Tasks

T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog
T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks"

Commits

rP2cb779575dd5: Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks"

Summary

Ref T11179. This splits "Edit Blocking Tasks" into two options now that we have more room ("Edit Parent Tasks", "Edit Subtasks").

This also renames "Blocking" tasks to "Subtasks", and "Blocked" tasks to "Parent" tasks. My goals here are:

Make the relationship direction more clear: it's more clear which way is up with "parent" and "subtask" at a glance than with "blocking" and "blocked" or "dependent" and "dependency".
Align language with "Create Subtask".
To some small degree, use more flexible/general-purpose language, although I haven't seen any real confusion here.

Fixes T6815. I think I narrowed this down to two issues:

Just throwing a bare exeception (we now return a dialog explicitly).
Not killing open transactions when the cyclec check fails (we now kill them).

Test Plan

Edited parent tasks.
Edited subtasks.
Tried to introduce graph cycles, got a nice error dialog.

Screen Shot 2016-06-22 at 10.25.06 AM.png (267×369 px, 23 KB)

Screen Shot 2016-06-22 at 10.35.10 AM.png (202×578 px, 19 KB)

Diff Detail

Repository

rP Phabricator

Branch

relation5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12765
Build 16248: Run Core Tests
Build 16247: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	19 ms	PhabricatorSpacesTestCase::Unknown Unit Message ("") EXCEPTION (Exception): Too many calls to saveTransaction() or killTransaction()! #0 /core/data/drydock/workingcopy-74/repo/libphutil/src/aphront/storage/connection/AphrontDatabaseConnection.php(168): AphrontDatabaseTransactionState->decreaseDepth() #1 /core/data/drydock/workingcopy-74/repo/phabricator/src/infrastructure/storage/lisk/LiskDAO.php(1610): AphrontDatabaseConnection->killTransaction()
	0 ms	PhabricatorSpacesTestCase::Unknown Unit Message ("") EXCEPTION (Exception): Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction(). #0 /core/data/drydock/workingcopy-74/repo/phabricator/src/infrastructure/storage/lisk/LiskDAO.php(0): AphrontDatabaseTransactionState->__destruct() #1 /core/data/drydock/workingcopy-74/repo/phabricator/src/infrastructure/storage/lisk/LiskDAO.php(1594): LiskDAO::closeAllConnections()
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 4 assertions passed.
		View Full Test Results (2 Failed · 326 Passed)

Event Timeline

epriestley updated this revision to Diff 38884.Jun 22 2016, 5:36 PM

epriestley retitled this revision from to Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks", T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

Those tests are likely me, let me look at 'em.

(I don't love these icons but didn't immediately see anything better.)

Fix tests by moving an existing transaction kill up a level.

I think I got all the "blocking / blocked" language except Maniphest search filters, but those have some outstanding bugs (T8126, some others?) so I figured I'd wait until I resolve those to sort them out.

chad accepted this revision.Jun 22 2016, 6:10 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2016, 6:10 PM

epriestley mentioned this in T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.Jun 22 2016, 6:14 PM

Closed by commit rP2cb779575dd5: Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks" (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2016, 6:20 PM

This revision was automatically updated to reflect the committed changes.

Luke081515.2 awarded a token.Jun 22 2016, 6:37 PM

20after4 mentioned this in D15560: Improve task dependency queries (Fixes T8126).Jul 20 2016, 8:00 PM