Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks"


Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks"

Ref T11179. This splits "Edit Blocking Tasks" into two options now that we have more room ("Edit Parent Tasks", "Edit Subtasks").

This also renames "Blocking" tasks to "Subtasks", and "Blocked" tasks to "Parent" tasks. My goals here are:

  • Make the relationship direction more clear: it's more clear which way is up with "parent" and "subtask" at a glance than with "blocking" and "blocked" or "dependent" and "dependency".
  • Align language with "Create Subtask".
  • To some small degree, use more flexible/general-purpose language, although I haven't seen any real confusion here.

Fixes T6815. I think I narrowed this down to two issues:

  • Just throwing a bare exeception (we now return a dialog explicitly).
  • Not killing open transactions when the cyclec check fails (we now kill them).

Test Plan:

  • Edited parent tasks.
  • Edited subtasks.
  • Tried to introduce graph cycles, got a nice error dialog.

Screen Shot 2016-06-22 at 10.25.06 AM.png (267×369 px, 23 KB)

Screen Shot 2016-06-22 at 10.35.10 AM.png (202×578 px, 19 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T6815, T11179

Differential Revision: https://secure.phabricator.com/D16166