Page MenuHomePhabricator

Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks"

Authored by epriestley on Jun 22 2016, 5:36 PM.
Referenced Files
Unknown Object (File)
Thu, Nov 30, 2:15 AM
Unknown Object (File)
Mon, Nov 27, 6:02 PM
Unknown Object (File)
Sat, Nov 25, 3:41 PM
Unknown Object (File)
Sat, Nov 25, 5:17 AM
Unknown Object (File)
Wed, Nov 15, 11:02 PM
Unknown Object (File)
Nov 6 2023, 7:02 AM
Unknown Object (File)
Oct 24 2023, 8:59 AM
Unknown Object (File)
Oct 19 2023, 10:26 AM
"Like" token, awarded by Luke081515.2.



Ref T11179. This splits "Edit Blocking Tasks" into two options now that we have more room ("Edit Parent Tasks", "Edit Subtasks").

This also renames "Blocking" tasks to "Subtasks", and "Blocked" tasks to "Parent" tasks. My goals here are:

  • Make the relationship direction more clear: it's more clear which way is up with "parent" and "subtask" at a glance than with "blocking" and "blocked" or "dependent" and "dependency".
  • Align language with "Create Subtask".
  • To some small degree, use more flexible/general-purpose language, although I haven't seen any real confusion here.

Fixes T6815. I think I narrowed this down to two issues:

  • Just throwing a bare exeception (we now return a dialog explicitly).
  • Not killing open transactions when the cyclec check fails (we now kill them).
Test Plan
  • Edited parent tasks.
  • Edited subtasks.
  • Tried to introduce graph cycles, got a nice error dialog.

Screen Shot 2016-06-22 at 10.25.06 AM.png (267×369 px, 23 KB)

Screen Shot 2016-06-22 at 10.35.10 AM.png (202×578 px, 19 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Those tests are likely me, let me look at 'em.

(I don't love these icons but didn't immediately see anything better.)

  • Fix tests by moving an existing transaction kill up a level.

I think I got all the "blocking / blocked" language except Maniphest search filters, but those have some outstanding bugs (T8126, some others?) so I figured I'd wait until I resolve those to sort them out.

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2016, 6:10 PM
This revision was automatically updated to reflect the committed changes.