Page MenuHomePhabricator
Differential D14010

Test XHPAST linter rules in isolation
ClosedPublic
Actions

Authored by joshuaspence on Aug 30 2015, 3:13 AM.
Tags
None
Referenced Files
F14087000: D14010.diff
Sat, Nov 23, 6:31 PM
Unknown Object (File)
Wed, Nov 20, 1:34 PM
Unknown Object (File)
Mon, Nov 18, 1:46 AM
Unknown Object (File)
Sat, Nov 16, 10:14 AM
Unknown Object (File)
Tue, Nov 12, 1:38 AM
Unknown Object (File)
Mon, Nov 11, 5:37 PM
Unknown Object (File)
Mon, Nov 11, 12:36 PM
Unknown Object (File)
Fri, Nov 8, 11:17 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC4d512c51d43c: Test XHPAST linter rules in isolation
Summary

Separate XHPAST linter rules in isolation from other rules and formalize the concept of a "linter rule". As the number of XHPAST linter rules grows (we currently have around 80), it becomes increasingly difficult to manage all of the test cases because ArcanistXHPASTLinterTestCase currently tests the entire linter (i.e. all linter rules) rather than testing individual rules in isolation. See D13534 for a situation in which this is painful. This is particularly bad for third party development because unit tests could break at any time depending on upstream changes.

Basically, in order to facilitate the unit testing of XHPAST linter rules in isolation, I have made the following changes:

  1. Added a setRules() method to ArcanistXHPASTLinter. Currently, ArcanistXHPASTLinter loads all ArcanistXHPASTLinterRule subclasses unconditionally. The setRules() method provides a way to override the configured linter rules.
  2. Formalize the concept of a "linter rule". The ArcanistXHPASTLinterRule class was introduced in D10541. I feel that the modularization of ArcanistXHPASTLinter has made the linter much more maintainable and easily testable and I intend to extend this concept to other linters, such as ArcanistTextLinter.
Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/lint/linter/xhpast/ArcanistXHPASTLinterRule.php:145XHP16TODO Comment
Advicesrc/lint/linter/xhpast/ArcanistXHPASTLinterRule.php:188XHP16TODO Comment
Unit
Test Failures
Build Status
Buildable 8856
Build 10352: Run Core Tests
Build 10351: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
352 msArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
15 msArcanistRubyLinterTestCase::Unknown Unit Message ("")
21 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
14 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
18 msArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("")
View Full Test Results (2 Failed · 259 Passed · 48 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33870.Aug 30 2015, 3:13 AM
joshuaspence retitled this revision from to Test XHPAST linter rules in isolation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 30 2015, 3:13 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 33871.Aug 30 2015, 10:49 AM
joshuaspence edited edge metadata.

Almost working...

joshuaspence mentioned this in D13534: Add a linter rule for newlines after PHP open tags.Aug 30 2015, 11:51 AM
joshuaspence updated this object.Aug 30 2015, 8:52 PM
joshuaspence updated this object.Aug 30 2015, 9:12 PM
joshuaspence updated this revision to Diff 33882.Aug 30 2015, 9:37 PM

Almost there...

joshuaspence updated this revision to Diff 33883.Aug 30 2015, 9:56 PM

Fix failing test

• asarrafi mentioned this in D14024: Fix unsafe string for static method calls.Sep 1 2015, 12:16 AM
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM
joshuaspence updated this revision to Diff 35009.Nov 13 2015, 11:12 AM

Rebase

joshuaspence updated this revision to Diff 35010.Nov 13 2015, 11:24 AM

Fix a unit test

joshuaspence added a child revision: D14024: Fix unsafe string for static method calls.Nov 13 2015, 11:32 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a child revision: D14443: Add a linter rule for `parent` references.Nov 14 2015, 10:42 AM
joshuaspence mentioned this in D14443: Add a linter rule for `parent` references.Nov 14 2015, 10:46 AM
joshuaspence updated this revision to Diff 35046.Nov 15 2015, 9:34 AM

Update editorconfig

joshuaspence added a child revision: D14488: Add some additional unit tests.Nov 16 2015, 12:03 PM
joshuaspence added a comment.Nov 18 2015, 8:18 PM

@epriestley, apologies for the large diff. 95% of this diff is either:

  • Moving test data from src/lint/linter/__tests__/xhpast/ to src/lint/linter/xhpast/rules/__tests/.
  • Boilerplate code for implementing ArcanistXHPASTLinterRule.

The only substantial code changes are the following classes/files:

  • .editorconfig
  • ArcanistXHPASTLinter
  • ArcanistLinterTestCase
  • ArcanistXHPASTLinterRule
joshuaspence updated this object.Nov 18 2015, 8:19 PM
joshuaspence mentioned this in D13935: Improve the "self member reference" linter rule.Nov 18 2015, 8:36 PM
joshuaspence added a child revision: D13935: Improve the "self member reference" linter rule.Nov 18 2015, 8:38 PM
epriestley accepted this revision.Nov 18 2015, 9:36 PM
epriestley edited edge metadata.

It might be vaguely nice to put these in some directory like:

.../__tests__/xhpast/data/XHP123/test1.lint-test

...and then use the directory (XHP123) as a code to select which lint messages to allow, then run all the directories as one test case. Then you can add a new rule test by just adding a directory instead of also having to add a class for it, and don't need to do the "guess the rule from the class name" stuff.

You may not be able to map rules cleanly to codes, but you could just run all the rules, then throw away the messages with a different code (instead of running only relevant rules).

Alternatively, rule stuff could be in some standard rules.json in the test directories as a sort of middle ground (more work than just directories but less work than creating classes).

I don't think any of these approaches are hugely better than the others, just proving that I'm reviewing. :)

This revision is now accepted and ready to land.Nov 18 2015, 9:36 PM
joshuaspence added a comment.Nov 18 2015, 9:56 PM
In D14010#163478, @epriestley wrote:

It might be vaguely nice to put these in some directory like:

.../__tests__/xhpast/data/XHP123/test1.lint-test

...and then use the directory (XHP123) as a code to select which lint messages to allow, then run all the directories as one test case. Then you can add a new rule test by just adding a directory instead of also having to add a class for it, and don't need to do the "guess the rule from the class name" stuff.

You may not be able to map rules cleanly to codes, but you could just run all the rules, then throw away the messages with a different code (instead of running only relevant rules).

Alternatively, rule stuff could be in some standard rules.json in the test directories as a sort of middle ground (more work than just directories but less work than creating classes).

I don't think any of these approaches are hugely better than the others, just proving that I'm reviewing. :)

That's vaguely nice but I'm going to hold off for now because longer term I'm not sure that IDs are the best fit for linter rules. That is, who really has any idea what XHP123 is?

Closed by commit rARC4d512c51d43c: Test XHPAST linter rules in isolation (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 18 2015, 9:57 PM
This revision was automatically updated to reflect the committed changes.
vm mentioned this in D15123: Fix linter tests.Jan 28 2016, 12:14 AM

Large Diff

This large diff affects 268 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
2 lines
src/
154 lines
lint/
linter/
10 lines
2 lines
17 lines
__tests__/
11 lines
14 lines
php/
2 lines
xhpast/
44 lines
xhpast/
120 lines
__tests__/
rules/
__tests__/
10 lines
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
10 lines
10 lines
11 lines
11 lines
11 lines
11 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
11 lines
11 lines
10 lines
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
11 lines
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
11 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
11 lines
11 lines
10 lines
11 lines
10 lines
11 lines
10 lines
32 lines
concatenation-operator/
26 lines
exit-expression/
8 lines
xhpast/
rules/
__tests__/
__tests__/
__lambda_func-function/
xhpast/
5 lines
__toString-exception/
xhpast/
__toString-exception.lint-test
tostring-exception.lint-test
5 lines
alias-functions/
xhpast/
4 lines
array-combine/
xhpast/
6 lines
array-index-spacing/
xhpast/
array-index-spacing.lint-test
array-index.lint-test
6 lines
array-separator/
xhpast/
array-separator.lint-test
array-comma.lint-test
81 lines
array-value/
xhpast/
56 lines
binary-expression-spacing/
xhpast/
array.lint-test
space-around-more-operators.lint-test
30 lines
binary-expression-spacing.lint-test
space-around-operators.lint-test
65 lines
blacklisted-function/
xhpast/
blacklisted-function.lint-test
blacklisted.lint-test
14 lines
brace-formatting/
xhpast/
brace-formatting.lint-test
creative-brace-use.lint-test
10 lines
call-parentheses/
xhpast/
array.lint-test
array-formatting.lint-test
11 lines
call-parentheses.lint-test
call-parens-hug-closing.lint-test
42 lines
call-time-pass-by-reference/
xhpast/
3 lines
cast-spacing/
xhpast/
14 lines
class-extends-object/
xhpast/
7 lines
class-name-literal/
xhpast/
3 lines
comment-style/
xhpast/
12 lines
constructor-parentheses/
xhpast/
14 lines
control-statement-spacing/
xhpast/
control-statement-spacing.lint-test
space-after-control-keywords.lint-test
10 lines
declaration-parentheses/
xhpast/
declaration-parentheses.lint-test
decl-parens-hug-closing.lint-test
2 lines
default-parameters/
xhpast/
3 lines
deprecation/
xhpast/
15 lines
double-quote/
xhpast/
31 lines
duplicate-keys-in-array/
xhpast/
duplicate-keys-in-array.lint-test
duplicate-key-in-array.lint-test
43 lines
duplicate-switch-case/
xhpast/
29 lines
dynamic-define/
xhpast/
9 lines
elseif-usage/
xhpast/
elseif-usage.lint-test
elseif.lint-test
21 lines
empty-statement/
xhpast/
empty-statement.lint-test
empty-block-statement.lint-test
23 lines
extract-use/
xhpast/
5 lines
formatted-string/
xhpast/
28 lines
global-variable/
xhpast/
global-variable.lint-test
global-variables.lint-test
9 lines
implicit-constructor/
xhpast/
implicit-constructor.lint-test
surprising-constructors.lint-test
2 lines
implicit-fallthrough/
xhpast/
1 line
implicit-visibility/
xhpast/
2 lines
inline-html/
xhpast/
4 lines
inner-function/
xhpast/
14 lines
instanceof-operator/
xhpast/
10 lines
invalid-default-parameter/
xhpast/
18 lines
invalid-modifiers/
xhpast/
3 lines
keyword-casing/
xhpast/
46 lines
language-construct-parentheses/
xhpast/
50 lines
list-assignment/
xhpast/
13 lines
logical-operators/
xhpast/
22 lines
lowercase-functions/
xhpast/
11 lines
modifier-ordering/
xhpast/
3 lines
naming-conventions/
xhpast/
3 lines
3 lines
newline-after-open-tag/
xhpast/
24 lines
no-parent-scope/
xhpast/
1 line
object-operator-spacing/
xhpast/
object-operator-spacing.lint-test
object-operating-spacing.lint-test
14 lines
parentheses-spacing/
xhpast/
array.lint-test
array-formatting.lint-test
6 lines
parentheses-spacing.lint-test
parens-hug-contents.lint-test
2 lines
parse_str-use/
xhpast/
7 lines
php-compatibility/
xhpast/
1 line
12 lines
14 lines
14 lines
27 lines
1 line
18 lines
13 lines
php-echo-tag/
xhpast/
php-echo-tag.lint-test
php-tags-echo-form.lint-test
4 lines
php-open-tag/
xhpast/
php-open-tag.lint-test
php-tags-bad.lint-test
1 line
4 lines
5 lines
php-short-tag/
xhpast/
php-short-tag.lint-test
php-tags-short.lint-test
3 lines
plus-operator-on-strings/
xhpast/
plus-operator-on-strings.lint-test
wrong-concat-operator.lint-test
10 lines
preg_quote-misuse/
xhpast/
preg_quote-misuse.lint-test
preg-quote.lint-test
11 lines
ragged-classtree-edge/
xhpast/
ragged-classtree-edge.lint-test
ragged-classtree-edges.lint-test
12 lines
reused-as-iterator/
xhpast/
reused-as-iterator.lint-test
reused-local.lint-test
67 lines
reused-iterator-reference/
xhpast/
2 lines
reused-iterator/
xhpast/
reused-iterator.lint-test
reused-iterators.lint-test
58 lines
self-member-reference/
xhpast/
php53.lint-test
self-member-references-php53.lint-test
1 line
php54.lint-test
self-member-references-php54.lint-test
1 line
self-member-reference.lint-test
self-member-references.lint-test
2 lines
semicolon-spacing/
xhpast/
16 lines
slowness/
xhpast/
14 lines
static-this/
xhpast/
static-this.lint-test
use-of-this-in-static-method.lint-test
4 lines
tautological-expression/
xhpast/
tautological-expression.lint-test
tautological-expressions.lint-test
23 lines
todo-comment/
xhpast/
10 lines
unary-postfix-expression-spacing/
xhpast/
11 lines
unary-prefix-expression-spacing/
xhpast/
14 lines
undeclared-variable/
xhpast/
undeclared-variable.lint-test
undeclared-variables.lint-test
9 lines
unnecessary-final-modifier/
xhpast/
2 lines
unsafe-dynamic-string/
xhpast/
2 lines
15 lines
useless-overriding-method/
xhpast/
1 line
variable-variable/
xhpast/
6 lines

Diff 35046

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/ArcanistLinter.php

View Options

src/lint/linter/ArcanistSpellingLinter.php

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

View Options

src/lint/linter/__tests__/ArcanistSpellingLinterTestCase.php

View Options

src/lint/linter/__tests__/php/no-errors.lint-test

View Options

src/lint/linter/__tests__/xhpast/alias-functions.lint-test

View Options

src/lint/linter/__tests__/xhpast/array-combine.lint-test

View Options

src/lint/linter/__tests__/xhpast/array-comma.lint-test

View Options

src/lint/linter/__tests__/xhpast/array-formatting.lint-test

View Options

src/lint/linter/__tests__/xhpast/array-index.lint-test

View Options

src/lint/linter/__tests__/xhpast/array-value.lint-test

View Options

src/lint/linter/__tests__/xhpast/blacklisted.lint-test

View Options

src/lint/linter/__tests__/xhpast/call-parens-hug-closing.lint-test

View Options

src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test

View Options

src/lint/linter/__tests__/xhpast/cast-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/class-name-literal.lint-test

View Options

src/lint/linter/__tests__/xhpast/conditional-usage.lint-test

View Options

src/lint/linter/__tests__/xhpast/constant-case.lint-test

View Options

src/lint/linter/__tests__/xhpast/constructor-parentheses.lint-test

View Options

src/lint/linter/__tests__/xhpast/creative-brace-use.lint-test

View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

View Options

src/lint/linter/__tests__/xhpast/default-parameters.lint-test

View Options

src/lint/linter/__tests__/xhpast/deprecated-function.lint-test

View Options

src/lint/linter/__tests__/xhpast/double-quote.lint-test

View Options

src/lint/linter/__tests__/xhpast/duplicate-key-in-array.lint-test

View Options

src/lint/linter/__tests__/xhpast/duplicate-switch-case.lint-test

View Options

src/lint/linter/__tests__/xhpast/dynamic-define.lint-test

View Options

src/lint/linter/__tests__/xhpast/elseif.lint-test

View Options

src/lint/linter/__tests__/xhpast/empty-block-statement.lint-test

View Options

src/lint/linter/__tests__/xhpast/empty-statement.lint-test

View Options

src/lint/linter/__tests__/xhpast/exit-expression.lint-test

View Options

src/lint/linter/__tests__/xhpast/extends-phobject.lint-test

View Options

src/lint/linter/__tests__/xhpast/extract-use.lint-test

View Options

src/lint/linter/__tests__/xhpast/formatted-string.lint-test

View Options

src/lint/linter/__tests__/xhpast/global-variables.lint-test

View Options

src/lint/linter/__tests__/xhpast/hash-comments.lint-test

View Options

src/lint/linter/__tests__/xhpast/implicit-visibility.lint-test

View Options

src/lint/linter/__tests__/xhpast/index-function.lint-test

View Options

src/lint/linter/__tests__/xhpast/inline-html.lint-test

View Options

src/lint/linter/__tests__/xhpast/inner-function.lint-test

View Options

src/lint/linter/__tests__/xhpast/instanceof-operator.lint-test

View Options

src/lint/linter/__tests__/xhpast/invalid-default-parameter.lint-test

View Options

src/lint/linter/__tests__/xhpast/invalid-modifiers.lint-test

View Options

src/lint/linter/__tests__/xhpast/keyword-casing.lint-test

View Options

src/lint/linter/__tests__/xhpast/lamba-func-function.lint-test

View Options

src/lint/linter/__tests__/xhpast/language-construct-parentheses.lint-test

View Options

src/lint/linter/__tests__/xhpast/list-assignment.lint-test

View Options

src/lint/linter/__tests__/xhpast/logical-operators.lint-test

View Options

src/lint/linter/__tests__/xhpast/lowercase-functions.lint-test

View Options

src/lint/linter/__tests__/xhpast/modifier-ordering.lint-test

View Options

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

View Options

src/lint/linter/__tests__/xhpast/newline-after-open-tag.lint-test

View Options

src/lint/linter/__tests__/xhpast/no-parent-scope.lint-test

View Options

src/lint/linter/__tests__/xhpast/nowdoc.lint-test

View Options

src/lint/linter/__tests__/xhpast/object-operating-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/parens-hug-contents.lint-test

View Options

src/lint/linter/__tests__/xhpast/parse_str-use.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-compatibility.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-bad.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-echo-form.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-good.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-script.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-short.lint-test

View Options

src/lint/linter/__tests__/xhpast/php53-features.lint-test

View Options

src/lint/linter/__tests__/xhpast/php54-features.lint-test

View Options

src/lint/linter/__tests__/xhpast/php54-incompat.lint-test

View Options

src/lint/linter/__tests__/xhpast/pht.lint-test

View Options

src/lint/linter/__tests__/xhpast/preg-quote.lint-test

View Options

src/lint/linter/__tests__/xhpast/ragged-classtree-edges.lint-test

View Options

src/lint/linter/__tests__/xhpast/reused-iterator-reference.lint-test

View Options

src/lint/linter/__tests__/xhpast/reused-iterators.lint-test

View Options

src/lint/linter/__tests__/xhpast/reused-local.lint-test

View Options

src/lint/linter/__tests__/xhpast/self-member-references-php53.lint-test

View Options

src/lint/linter/__tests__/xhpast/self-member-references-php54.lint-test

View Options

src/lint/linter/__tests__/xhpast/self-member-references.lint-test

View Options

src/lint/linter/__tests__/xhpast/semicolon-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/slowness.lint-test

View Options

src/lint/linter/__tests__/xhpast/space-after-control-keywords.lint-test

View Options

src/lint/linter/__tests__/xhpast/space-around-more-operators.lint-test

View Options

src/lint/linter/__tests__/xhpast/space-around-operators.lint-test

View Options

src/lint/linter/__tests__/xhpast/surprising-constructors.lint-test

View Options

src/lint/linter/__tests__/xhpast/switches.lint-test

View Options

src/lint/linter/__tests__/xhpast/tautological-expressions.lint-test

View Options

src/lint/linter/__tests__/xhpast/todo.lint-test

View Options

src/lint/linter/__tests__/xhpast/tostring-exception.lint-test

View Options

src/lint/linter/__tests__/xhpast/unary-postfix-expression-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/unary-prefix-expression-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/undeclared-variables.lint-test

View Options

src/lint/linter/__tests__/xhpast/unnecessary-final-modifier.lint-test

View Options

src/lint/linter/__tests__/xhpast/unreasonably-deep-nesting.lint-test

View Options

src/lint/linter/__tests__/xhpast/use-of-this-in-static-method.lint-test

View Options

src/lint/linter/__tests__/xhpast/useless-overriding-method.lint-test

View Options

src/lint/linter/__tests__/xhpast/variable-variables.lint-test

View Options

src/lint/linter/__tests__/xhpast/windows.lint-test

View Options

src/lint/linter/__tests__/xhpast/wrong-concat-operator.lint-test

View Options

src/lint/linter/__tests__/xhpast/xsprintf.lint-test

View Options

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/__tests__/ArcanistXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistAliasFunctionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistArrayCombineXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistArrayIndexSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistArraySeparatorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistArrayValueXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistBinaryExpressionSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistBlacklistedFunctionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistBraceFormattingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistCallParenthesesXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistCallTimePassByReferenceXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistCastSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistClassExtendsObjectXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistClassNameLiteralXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistCommentStyleXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistConcatenationOperatorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistConstructorParenthesesXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistControlStatementSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDeclarationParenthesesXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDefaultParametersXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDeprecationXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDoubleQuoteXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDuplicateKeysInArrayXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDuplicateSwitchCaseXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDynamicDefineXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistElseIfUsageXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistEmptyStatementXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistExitExpressionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistExtractUseXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistFormattedStringXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistGlobalVariableXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistImplicitConstructorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistImplicitFallthroughXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistImplicitVisibilityXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInlineHTMLXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInnerFunctionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInstanceofOperatorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInvalidDefaultParameterXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInvalidModifiersXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistKeywordCasingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistLambdaFuncFunctionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistLanguageConstructParenthesesXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistListAssignmentXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistLogicalOperatorsXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistLowercaseFunctionsXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistModifierOrderingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistNamingConventionsXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistNewlineAfterOpenTagXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistNoParentScopeXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistObjectOperatorSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPCompatibilityXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPEchoTagXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPOpenTagXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPShortTagXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistParenthesesSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistParseStrUseXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPlusOperatorOnStringsXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPregQuoteMisuseXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistRaggedClassTreeEdgeXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistReusedAsIteratorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistReusedIteratorReferenceXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistReusedIteratorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistSelfMemberReferenceXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistSemicolonSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistSlownessXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistStaticThisXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistTautologicalExpressionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistToStringExceptionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistTodoCommentXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUnaryPostfixExpressionSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUnaryPrefixExpressionSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUndeclaredVariableXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUnnecessaryFinalModifierXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUnsafeDynamicStringXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUselessOverridingMethodXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistVariableVariableXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/__lambda_func-function/lamba-func-function.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/__toString-exception/__toString-exception.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/alias-functions/alias-functions.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/array-combine/array-combine.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/array-index-spacing/array-index-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/array-separator/array-separator.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/array-value/array-value.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/binary-expression-spacing/array.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/binary-expression-spacing/binary-expression-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/blacklisted-function/blacklisted-function.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/brace-formatting/brace-formatting.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/call-parentheses/array.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/call-parentheses/call-parentheses.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/call-time-pass-by-reference/call-time-pass-by-reference.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/cast-spacing/cast-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/class-extends-object/extends-phobject.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/class-name-literal/class-name-literal.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/comment-style/hash-comments.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/concatenation-operator/concatenation-operator.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/constructor-parentheses/constructor-parentheses.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/control-statement-spacing/control-statement-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/declaration-parentheses/declaration-parentheses.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/default-parameters/default-parameters.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-function.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/double-quote/double-quote.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/duplicate-keys-in-array/duplicate-keys-in-array.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/duplicate-switch-case/duplicate-switch-case.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/dynamic-define/dynamic-define.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/elseif-usage/elseif-usage.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/empty-statement/empty-statement.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/exit-expression/exit-expression.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/extract-use/extract-use.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/formatted-string/formatted-string.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/global-variable/global-variable.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/implicit-constructor/implicit-constructor.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/implicit-fallthrough/implicit-fallthrough.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/implicit-visibility/implicit-visibility.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/inline-html/inline-html.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/inner-function/inner-function.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/instanceof-operator/instanceof-operator.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/invalid-default-parameter/invalid-default-parameter.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/invalid-modifiers/invalid-modifiers.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/keyword-casing/keyword-casing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/language-construct-parentheses/language-construct-parentheses.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/list-assignment/list-assignment.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/logical-operators/logical-operators.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/lowercase-functions/lowercase-functions.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/modifier-ordering/modifier-ordering.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/naming-conventions/constant-case.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/naming-conventions/naming-conventions.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/newline-after-open-tag/newline-after-open-tag.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/no-parent-scope/no-parent-scope.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/object-operator-spacing/object-operator-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/parentheses-spacing/array.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/parentheses-spacing/parentheses-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/parse_str-use/parse_str-use.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/conditional-usage.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/index-function.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/nowdoc.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/php-compatibility.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/php53-features.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/php54-features.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/php54-incompat.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/windows.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-echo-tag/php-echo-tag.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-open-tag/php-open-tag.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-open-tag/php-tags-good.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-open-tag/php-tags-script.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-short-tag/php-short-tag.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/plus-operator-on-strings/plus-operator-on-strings.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/preg_quote-misuse/preg_quote-misuse.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/ragged-classtree-edge/ragged-classtree-edge.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/reused-as-iterator/reused-as-iterator.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/reused-iterator-reference/reused-iterator-reference.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/reused-iterator/reused-iterator.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/self-member-reference/php53.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/self-member-reference/php54.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/self-member-reference/self-member-reference.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/semicolon-spacing/semicolon-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/slowness/slowness.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/static-this/static-this.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/tautological-expression/tautological-expression.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/todo-comment/todo-comment.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/unary-postfix-expression-spacing/unary-postfix-expression-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/unary-prefix-expression-spacing/unary-prefix-expression-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/undeclared-variable/undeclared-variable.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/unnecessary-final-modifier/unnecessary-final-modifier.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/unsafe-dynamic-string/pht.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/unsafe-dynamic-string/xsprintf.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/useless-overriding-method/useless-overriding-method.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/variable-variable/variable-variables.lint-test

Phabricator · Built by Phacility