Page MenuHomePhabricator
Differential D14010

Test XHPAST linter rules in isolation
ClosedPublic
Actions

Authored by joshuaspence on Aug 30 2015, 3:13 AM.
Tags
None
Referenced Files
F14087000: D14010.diff
Sat, Nov 23, 6:31 PM
Unknown Object (File)
Wed, Nov 20, 1:34 PM
Unknown Object (File)
Mon, Nov 18, 1:46 AM
Unknown Object (File)
Sat, Nov 16, 10:14 AM
Unknown Object (File)
Tue, Nov 12, 1:38 AM
Unknown Object (File)
Mon, Nov 11, 5:37 PM
Unknown Object (File)
Mon, Nov 11, 12:36 PM
Unknown Object (File)
Fri, Nov 8, 11:17 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC4d512c51d43c: Test XHPAST linter rules in isolation
Summary

Separate XHPAST linter rules in isolation from other rules and formalize the concept of a "linter rule". As the number of XHPAST linter rules grows (we currently have around 80), it becomes increasingly difficult to manage all of the test cases because ArcanistXHPASTLinterTestCase currently tests the entire linter (i.e. all linter rules) rather than testing individual rules in isolation. See D13534 for a situation in which this is painful. This is particularly bad for third party development because unit tests could break at any time depending on upstream changes.

Basically, in order to facilitate the unit testing of XHPAST linter rules in isolation, I have made the following changes:

  1. Added a setRules() method to ArcanistXHPASTLinter. Currently, ArcanistXHPASTLinter loads all ArcanistXHPASTLinterRule subclasses unconditionally. The setRules() method provides a way to override the configured linter rules.
  2. Formalize the concept of a "linter rule". The ArcanistXHPASTLinterRule class was introduced in D10541. I feel that the modularization of ArcanistXHPASTLinter has made the linter much more maintainable and easily testable and I intend to extend this concept to other linters, such as ArcanistTextLinter.
Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/lint/linter/xhpast/ArcanistXHPASTLinterRule.php:80XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 7850
Build 8731: [Placeholder Plan] Wait for 30 Seconds
Build 8730: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33870.Aug 30 2015, 3:13 AM
joshuaspence retitled this revision from to Test XHPAST linter rules in isolation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 30 2015, 3:13 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 33871.Aug 30 2015, 10:49 AM
joshuaspence edited edge metadata.

Almost working...

joshuaspence mentioned this in D13534: Add a linter rule for newlines after PHP open tags.Aug 30 2015, 11:51 AM
joshuaspence updated this object.Aug 30 2015, 8:52 PM
joshuaspence updated this object.Aug 30 2015, 9:12 PM
joshuaspence updated this revision to Diff 33882.Aug 30 2015, 9:37 PM

Almost there...

joshuaspence updated this revision to Diff 33883.Aug 30 2015, 9:56 PM

Fix failing test

• asarrafi mentioned this in D14024: Fix unsafe string for static method calls.Sep 1 2015, 12:16 AM
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM
joshuaspence updated this revision to Diff 35009.Nov 13 2015, 11:12 AM

Rebase

joshuaspence updated this revision to Diff 35010.Nov 13 2015, 11:24 AM

Fix a unit test

joshuaspence added a child revision: D14024: Fix unsafe string for static method calls.Nov 13 2015, 11:32 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a child revision: D14443: Add a linter rule for `parent` references.Nov 14 2015, 10:42 AM
joshuaspence mentioned this in D14443: Add a linter rule for `parent` references.Nov 14 2015, 10:46 AM
joshuaspence updated this revision to Diff 35046.Nov 15 2015, 9:34 AM

Update editorconfig

joshuaspence added a child revision: D14488: Add some additional unit tests.Nov 16 2015, 12:03 PM
joshuaspence added a comment.Nov 18 2015, 8:18 PM

@epriestley, apologies for the large diff. 95% of this diff is either:

  • Moving test data from src/lint/linter/__tests__/xhpast/ to src/lint/linter/xhpast/rules/__tests/.
  • Boilerplate code for implementing ArcanistXHPASTLinterRule.

The only substantial code changes are the following classes/files:

  • .editorconfig
  • ArcanistXHPASTLinter
  • ArcanistLinterTestCase
  • ArcanistXHPASTLinterRule
joshuaspence updated this object.Nov 18 2015, 8:19 PM
joshuaspence mentioned this in D13935: Improve the "self member reference" linter rule.Nov 18 2015, 8:36 PM
joshuaspence added a child revision: D13935: Improve the "self member reference" linter rule.Nov 18 2015, 8:38 PM
epriestley accepted this revision.Nov 18 2015, 9:36 PM
epriestley edited edge metadata.

It might be vaguely nice to put these in some directory like:

.../__tests__/xhpast/data/XHP123/test1.lint-test

...and then use the directory (XHP123) as a code to select which lint messages to allow, then run all the directories as one test case. Then you can add a new rule test by just adding a directory instead of also having to add a class for it, and don't need to do the "guess the rule from the class name" stuff.

You may not be able to map rules cleanly to codes, but you could just run all the rules, then throw away the messages with a different code (instead of running only relevant rules).

Alternatively, rule stuff could be in some standard rules.json in the test directories as a sort of middle ground (more work than just directories but less work than creating classes).

I don't think any of these approaches are hugely better than the others, just proving that I'm reviewing. :)

This revision is now accepted and ready to land.Nov 18 2015, 9:36 PM
joshuaspence added a comment.Nov 18 2015, 9:56 PM
In D14010#163478, @epriestley wrote:

It might be vaguely nice to put these in some directory like:

.../__tests__/xhpast/data/XHP123/test1.lint-test

...and then use the directory (XHP123) as a code to select which lint messages to allow, then run all the directories as one test case. Then you can add a new rule test by just adding a directory instead of also having to add a class for it, and don't need to do the "guess the rule from the class name" stuff.

You may not be able to map rules cleanly to codes, but you could just run all the rules, then throw away the messages with a different code (instead of running only relevant rules).

Alternatively, rule stuff could be in some standard rules.json in the test directories as a sort of middle ground (more work than just directories but less work than creating classes).

I don't think any of these approaches are hugely better than the others, just proving that I'm reviewing. :)

That's vaguely nice but I'm going to hold off for now because longer term I'm not sure that IDs are the best fit for linter rules. That is, who really has any idea what XHP123 is?

Closed by commit rARC4d512c51d43c: Test XHPAST linter rules in isolation (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 18 2015, 9:57 PM
This revision was automatically updated to reflect the committed changes.
vm mentioned this in D15123: Fix linter tests.Jan 28 2016, 12:14 AM

Large Diff

This large diff affects 268 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
156 lines
lint/
linter/
10 lines
100 lines
2 lines
6 lines
__tests__/
29 lines
11 lines
15 lines
14 lines
xhpast/
xhpast/
139 lines
__tests__/
rules/
10 lines
11 lines
__tests__/
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
11 lines
11 lines
11 lines
11 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
11 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
11 lines
10 lines
10 lines
10 lines
10 lines
10 lines
11 lines
10 lines
10 lines
10 lines
11 lines
10 lines
11 lines
11 lines
11 lines
10 lines
15 lines
call-parentheses/
13 lines
concatenation-operator/
24 lines
xhpast/
rules/
__tests__/
__tests__/
alias-function/
xhpast/
8 lines
array-index-spacing/
xhpast/
12 lines
array-separator/
xhpast/
81 lines
array-value/
xhpast/
56 lines
binary-expression-spacing/
xhpast/
6 lines
32 lines
65 lines
blacklisted/
xhpast/
14 lines
brace-formatting/
xhpast/
10 lines
42 lines
call-parentheses/
xhpast/
42 lines
cast-spacing/
xhpast/
14 lines
class-name-literal/
xhpast/
7 lines
comment-style/
xhpast/
12 lines
compatibility/
xhpast/
1 line
12 lines
14 lines
14 lines
27 lines
3 lines
18 lines
13 lines
constructor-parentheses/
xhpast/
14 lines
control-statement-spacing/
xhpast/
10 lines
declaration-parentheses/
xhpast/
1 line
33 lines
default-parameters/
xhpast/
6 lines
double-quote/
xhpast/
31 lines
duplicate-array-keys/
xhpast/
43 lines
duplicate-switch-case/
xhpast/
29 lines
dynamic-define/
xhpast/
9 lines
elseif/
xhpast/
21 lines
empty-statement/
xhpast/
23 lines
exit-expression/
xhpast/
8 lines
extract-use/
xhpast/
5 lines
formatted-string/
xhpast/
28 lines
global-variable/
xhpast/
9 lines
implicit-constructor/
xhpast/
4 lines
implicit-fallthrough/
xhpast/
100 lines
implicit-visibility/
xhpast/
7 lines
inline-html/
xhpast/
4 lines
inner-function/
xhpast/
14 lines
instanceof-operator/
xhpast/
10 lines
invalid-default-parameter/
xhpast/
18 lines
invalid-modifiers/
xhpast/
10 lines
keyword-casing/
xhpast/
46 lines
lambda-func-function/
xhpast/
5 lines
language-construct-parentheses/
xhpast/
50 lines
list-assignment/
xhpast/
13 lines
logical-operators/
xhpast/
22 lines
lowercase-functions/
xhpast/
11 lines
modifier-ordering/
xhpast/
9 lines
naming-conventions/
xhpast/
1 line
45 lines
newline-after-open-tag/
xhpast/
24 lines
no-parent-scope/
xhpast/
19 lines
object-operator-spacing/
xhpast/
object-operator-spacing.lint-test
object-operating-spacing.lint-test
14 lines
parentheses-spacing/
xhpast/
6 lines
33 lines
parse/
xhpast/
5 lines
4 lines
88 lines
parse_str-use/
xhpast/
7 lines
pass-by-reference/
xhpast/
14 lines
php-echo-tag/
xhpast/
4 lines
php-open-tag/
xhpast/
1 line
1 line
4 lines
5 lines
php-short-tag/
xhpast/
8 lines
plus-operator-on-strings/
xhpast/
10 lines
preg-quote-misuse/
xhpast/
11 lines
reused-as-iterator/
xhpast/
67 lines
reused-iterator-reference/
xhpast/
2 lines
reused-iterator/
xhpast/
58 lines
self-member-reference/
xhpast/
1 line
1 line
1 line
semicolon-spacing/
xhpast/
16 lines
slowness/
xhpast/
14 lines
static-this/
xhpast/
4 lines
syntax/
xhpast/
4 lines
tautological-expression/
xhpast/
23 lines
todo-comment/
xhpast/
10 lines
tostring-exception/
xhpast/
27 lines
unary-postfix-expression-spacing/
xhpast/
11 lines
unary-prefix-expression-spacing/
xhpast/
14 lines
undeclared-variable/
xhpast/
6 lines
unnecessary-final-modifier/
xhpast/
4 lines
unnecessary-semicolon/
xhpast/
1 line
useless-overriding-method/
xhpast/
8 lines
variable-variable/
xhpast/
6 lines

Diff 33883

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/ArcanistLinter.php

View Options

src/lint/linter/ArcanistLinterRule.php

View Options

src/lint/linter/ArcanistSpellingLinter.php

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/__tests__/ArcanistLinterRuleTestCase.php

View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

View Options

src/lint/linter/__tests__/ArcanistPhutilXHPASTLinterTestCase.php

View Options

src/lint/linter/__tests__/ArcanistSpellingLinterTestCase.php

View Options

src/lint/linter/__tests__/xhpast/alias-functions.lint-test

View Options

src/lint/linter/__tests__/xhpast/array-comma.lint-test

View Options

src/lint/linter/__tests__/xhpast/array-formatting.lint-test

View Options

src/lint/linter/__tests__/xhpast/array-index.lint-test

View Options

src/lint/linter/__tests__/xhpast/array-value.lint-test

View Options

src/lint/linter/__tests__/xhpast/blacklisted.lint-test

View Options

src/lint/linter/__tests__/xhpast/call-parens-hug-closing.lint-test

View Options

src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test

View Options

src/lint/linter/__tests__/xhpast/cast-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/class-name-literal.lint-test

View Options

src/lint/linter/__tests__/xhpast/conditional-usage.lint-test

View Options

src/lint/linter/__tests__/xhpast/constant-case.lint-test

View Options

src/lint/linter/__tests__/xhpast/constructor-parentheses.lint-test

View Options

src/lint/linter/__tests__/xhpast/creative-brace-use.lint-test

View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

View Options

src/lint/linter/__tests__/xhpast/default-parameters.lint-test

View Options

src/lint/linter/__tests__/xhpast/double-quote.lint-test

View Options

src/lint/linter/__tests__/xhpast/duplicate-key-in-array.lint-test

View Options

src/lint/linter/__tests__/xhpast/duplicate-switch-case.lint-test

View Options

src/lint/linter/__tests__/xhpast/dynamic-define.lint-test

View Options

src/lint/linter/__tests__/xhpast/elseif.lint-test

View Options

src/lint/linter/__tests__/xhpast/embedded-tags.lint-test

View Options

src/lint/linter/__tests__/xhpast/empty-block-statement.lint-test

View Options

src/lint/linter/__tests__/xhpast/empty-statement.lint-test

View Options

src/lint/linter/__tests__/xhpast/exit-expression.lint-test

View Options

src/lint/linter/__tests__/xhpast/extract-use.lint-test

View Options

src/lint/linter/__tests__/xhpast/formatted-string.lint-test

View Options

src/lint/linter/__tests__/xhpast/global-variables.lint-test

View Options

src/lint/linter/__tests__/xhpast/hash-comments.lint-test

View Options

src/lint/linter/__tests__/xhpast/implicit-visibility.lint-test

View Options

src/lint/linter/__tests__/xhpast/index-function.lint-test

View Options

src/lint/linter/__tests__/xhpast/inline-html.lint-test

View Options

src/lint/linter/__tests__/xhpast/inner-function.lint-test

View Options

src/lint/linter/__tests__/xhpast/instanceof-operator.lint-test

View Options

src/lint/linter/__tests__/xhpast/invalid-default-parameter.lint-test

View Options

src/lint/linter/__tests__/xhpast/invalid-modifiers.lint-test

View Options

src/lint/linter/__tests__/xhpast/keyword-casing.lint-test

View Options

src/lint/linter/__tests__/xhpast/lamba-func-function.lint-test

View Options

src/lint/linter/__tests__/xhpast/language-construct-parentheses.lint-test

View Options

src/lint/linter/__tests__/xhpast/list-assignment.lint-test

View Options

src/lint/linter/__tests__/xhpast/logical-operators.lint-test

View Options

src/lint/linter/__tests__/xhpast/lowercase-functions.lint-test

View Options

src/lint/linter/__tests__/xhpast/modifier-ordering.lint-test

View Options

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

View Options

src/lint/linter/__tests__/xhpast/newline-after-open-tag.lint-test

View Options

src/lint/linter/__tests__/xhpast/no-parent-scope.lint-test

View Options

src/lint/linter/__tests__/xhpast/no-segfault-on-abstract.lint-test

View Options

src/lint/linter/__tests__/xhpast/no-segfault-on-exit.lint-test

View Options

src/lint/linter/__tests__/xhpast/nowdoc.lint-test

View Options

src/lint/linter/__tests__/xhpast/object-operating-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/parens-hug-contents.lint-test

View Options

src/lint/linter/__tests__/xhpast/parse_str-use.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-compatibility.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-bad.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-echo-form.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-good.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-script.lint-test

View Options

src/lint/linter/__tests__/xhpast/php-tags-short.lint-test

View Options

src/lint/linter/__tests__/xhpast/php53-features.lint-test

View Options

src/lint/linter/__tests__/xhpast/php54-features.lint-test

View Options

src/lint/linter/__tests__/xhpast/php54-incompat.lint-test

View Options

src/lint/linter/__tests__/xhpast/preg-quote.lint-test

View Options

src/lint/linter/__tests__/xhpast/reused-iterator-reference.lint-test

View Options

src/lint/linter/__tests__/xhpast/reused-iterators.lint-test

View Options

src/lint/linter/__tests__/xhpast/reused-local.lint-test

View Options

src/lint/linter/__tests__/xhpast/self-member-references-php53.lint-test

View Options

src/lint/linter/__tests__/xhpast/self-member-references-php54.lint-test

View Options

src/lint/linter/__tests__/xhpast/self-member-references.lint-test

View Options

src/lint/linter/__tests__/xhpast/semicolon-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/slowness.lint-test

View Options

src/lint/linter/__tests__/xhpast/space-after-control-keywords.lint-test

View Options

src/lint/linter/__tests__/xhpast/space-around-more-operators.lint-test

View Options

src/lint/linter/__tests__/xhpast/space-around-operators.lint-test

View Options

src/lint/linter/__tests__/xhpast/surprising-constructors.lint-test

View Options

src/lint/linter/__tests__/xhpast/switches.lint-test

View Options

src/lint/linter/__tests__/xhpast/syntax-error.lint-test

View Options

src/lint/linter/__tests__/xhpast/tautological-expressions.lint-test

View Options

src/lint/linter/__tests__/xhpast/todo.lint-test

View Options

src/lint/linter/__tests__/xhpast/tostring-exception.lint-test

View Options

src/lint/linter/__tests__/xhpast/unary-postfix-expression-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/unary-prefix-expression-spacing.lint-test

View Options

src/lint/linter/__tests__/xhpast/undeclared-variables.lint-test

View Options

src/lint/linter/__tests__/xhpast/unnecessary-final-modifier.lint-test

View Options

src/lint/linter/__tests__/xhpast/unreasonably-deep-nesting.lint-test

View Options

src/lint/linter/__tests__/xhpast/use-of-this-in-static-method.lint-test

View Options

src/lint/linter/__tests__/xhpast/useless-overriding-method.lint-test

View Options

src/lint/linter/__tests__/xhpast/variable-variables.lint-test

View Options

src/lint/linter/__tests__/xhpast/windows.lint-test

View Options

src/lint/linter/__tests__/xhpast/wrong-concat-operator.lint-test

View Options

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/__tests__/ArcanistXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/ArcanistSyntaxErrorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/ArcanistUnaryPostfixExpressionSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistAliasFunctionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistArrayIndexSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistArraySeparatorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistArrayValueXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistBinaryExpressionSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistBlacklistedFunctionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistBraceFormattingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistCallParenthesesXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistCallTimePassByReferenceXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistCastSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistClassNameLiteralXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistCommentStyleXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistConcatenationOperatorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistConstructorParenthesesXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistControlStatementSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDeclarationParenthesesXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDefaultParametersXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDoubleQuoteXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDuplicateKeysInArrayXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDuplicateSwitchCaseXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistDynamicDefineXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistElseIfUsageXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistEmptyStatementXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistExitExpressionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistExtractUseXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistFormattedStringXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistGlobalVariableXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistImplicitConstructorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistImplicitFallthroughXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistImplicitVisibilityXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInlineHTMLXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInnerFunctionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInstanceOfOperatorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInvalidDefaultParameterXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInvalidModifiersXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistKeywordCasingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistLambdaFuncFunctionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistLanguageConstructParenthesesXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistListAssignmentXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistLogicalOperatorsXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistLowercaseFunctionsXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistModifierOrderingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistNamingConventionsXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistNewlineAfterOpenTagXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistNoParentScopeXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistObjectOperatorSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPCompatibilityXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPEchoTagXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPOpenTagXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPShortTagXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistParenthesesSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistParseStrUseXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPlusOperatorOnStringsXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistPregQuoteMisuseXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistReusedAsIteratorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistReusedIteratorReferenceXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistReusedIteratorXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistSelfMemberReferenceXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistSemicolonSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistSlownessXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistStaticThisXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistTautologicalExpressionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistToStringExceptionXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistTodoCommentXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUnableToParseXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUnaryPrefixExpressionSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUndeclaredVariableXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUnnecessaryFinalModifierXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUnnecessarySemicolonXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistUselessOverridingMethodXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistVariableVariableXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/__tests__/alias-function/alias-functions.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/array-index-spacing/array-index.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/array-separator/array-comma.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/array-value/array-value.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/binary-expression-spacing/array-index.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/binary-expression-spacing/space-around-more-operators.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/binary-expression-spacing/space-around-operators.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/blacklisted/blacklisted.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/brace-formatting/creative-brace-use.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/brace-formatting/space-after-control-keywords.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/call-parentheses/array-formatting.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/call-parentheses/call-parens-hug-closing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/cast-spacing/cast-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/class-name-literal/class-name-literal.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/comment-style/hash-comments.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/compatibility/conditional-usage.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/compatibility/index-function.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/compatibility/nowdoc.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/compatibility/php-compatibility.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/compatibility/php53-features.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/compatibility/php54-features.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/compatibility/php54-incompat.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/compatibility/windows.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/concatenation-operator/space-around-more-operators.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/constructor-parentheses/constructor-parentheses.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/control-statement-spacing/space-after-control-keywords.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/declaration-parentheses/decl-parens-hug-closing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/declaration-parentheses/parens-hug-contents.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/default-parameters/default-parameters.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/double-quote/double-quote.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/duplicate-array-keys/duplicate-key-in-array.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/duplicate-switch-case/duplicate-switch-case.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/dynamic-define/dynamic-define.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/elseif/elseif.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/empty-statement/empty-block-statement.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/exit-expression/exit-expression.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/extract-use/extract-use.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/formatted-string/formatted-string.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/global-variable/global-variables.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/implicit-constructor/surprising-constructors.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/implicit-fallthrough/switches.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/implicit-visibility/implicit-visibility.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/inline-html/inline-html.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/inner-function/inner-function.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/instanceof-operator/instanceof-operator.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/invalid-default-parameter/invalid-default-parameter.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/invalid-modifiers/invalid-modifiers.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/keyword-casing/keyword-casing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/lambda-func-function/lamba-func-function.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/language-construct-parentheses/language-construct-parentheses.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/list-assignment/list-assignment.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/logical-operators/logical-operators.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/lowercase-functions/lowercase-functions.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/modifier-ordering/modifier-ordering.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/naming-conventions/constant-case.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/naming-conventions/naming-conventions.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/newline-after-open-tag/newline-after-open-tag.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/no-parent-scope/no-parent-scope.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/object-operator-spacing/object-operator-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/parentheses-spacing/array-formatting.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/parentheses-spacing/parens-hug-contents.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/parse/no-segfault-on-abstract.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/parse/no-segfault-on-exit.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/parse/unreasonably-deep-nesting.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/parse_str-use/parse_str-use.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/pass-by-reference/call-time-pass-by-reference.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-echo-tag/php-tags-echo-form.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-open-tag/embedded-tags.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-open-tag/php-tags-bad.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-open-tag/php-tags-good.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-open-tag/php-tags-script.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/php-short-tag/php-tags-short.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/plus-operator-on-strings/wrong-concat-operator.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/preg-quote-misuse/preg-quote.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/reused-as-iterator/reused-local.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/reused-iterator-reference/reused-iterator-reference.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/reused-iterator/reused-iterators.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/self-member-reference/self-member-references-php53.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/self-member-reference/self-member-references-php54.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/self-member-reference/self-member-references.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/semicolon-spacing/semicolon-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/slowness/slowness.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/static-this/use-of-this-in-static-method.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/syntax/syntax-error.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/tautological-expression/tautological-expressions.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/todo-comment/todo.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/tostring-exception/tostring-exception.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/unary-postfix-expression-spacing/unary-postfix-expression-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/unary-prefix-expression-spacing/unary-prefix-expression-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/undeclared-variable/undeclared-variables.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/unnecessary-final-modifier/unnecessary-final-modifier.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/unnecessary-semicolon/empty-statement.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/useless-overriding-method/useless-overriding-method.lint-test

View Options

src/lint/linter/xhpast/rules/__tests__/variable-variable/variable-variables.lint-test

Phabricator · Built by Phacility