Page MenuHomePhabricator
Differential D14024

Fix unsafe string for static method calls
Needs RevisionPublic
Actions

Authored by • asarrafi on Sep 1 2015, 12:16 AM.
Tags
None
Referenced Files
F15414095: D14024.diff
Wed, Mar 19, 11:10 PM
F15412605: D14024.diff
Wed, Mar 19, 1:58 PM
F15360777: D14024.id33911.diff
Tue, Mar 11, 10:12 AM
Unknown Object (File)
Feb 8 2025, 11:08 PM
Unknown Object (File)
Jan 24 2025, 8:50 AM
Unknown Object (File)
Jan 22 2025, 8:00 AM
Unknown Object (File)
Jan 21 2025, 9:46 AM
Unknown Object (File)
Jan 15 2025, 7:39 PM
View All Files
Subscribers
epriestley
This revision can not be accepted until the required legal agreements have been signed.

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Unsafe dynamic string moved to a new rule.

List of phabricator internal methods are moved to .arclint.

Depends on D14010.

Test Plan

Tested using unit tests

Diff Detail

Repository
rARC Arcanist
Branch
arcpatch-D14010
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7866
Build 8763: [Placeholder Plan] Wait for 30 Seconds
Build 8762: arc lint + arc unit

Event Timeline

• asarrafi updated this revision to Diff 33911.Sep 1 2015, 12:16 AM
• asarrafi retitled this revision from to fix unsafe string for static method calls.
• asarrafi updated this object.
• asarrafi edited the test plan for this revision. (Show Details)
• asarrafi added a reviewer: joshuaspence.
• asarrafi set the repository for this revision to rARC Arcanist.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 1 2015, 12:16 AM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: epriestley. · View Herald Transcript
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM
epriestley requested changes to this revision.Sep 10 2015, 11:23 AM
epriestley added a reviewer: epriestley.

We can't review this until you sign the CLA. See L28 Phacility Individual Contributor License Agreement.

This revision now requires changes to proceed.Sep 10 2015, 11:23 AM
joshuaspence retitled this revision from fix unsafe string for static method calls to Fix unsafe string for static method calls.Nov 13 2015, 11:32 AM
joshuaspence updated this object.
joshuaspence edited edge metadata.
joshuaspence added a parent revision: D14010: Test XHPAST linter rules in isolation.

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.
Phabricator · Built by Phacility