Paths

Table of Contentst

Diffusion Arcanist a5304e472d18

Add a linter rule for newlines after PHP open tags
a5304e472d18
Actions

Description

Add a linter rule for newlines after PHP open tags

Summary: <?php\n\n... is much easier to read than <?php\n.... Depends on D13889 and D13890.

Test Plan: Added unit tests.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13534

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Aug 30 2015, 8:52 PM

Reviewer

Blessed Reviewers

Differential Revision

D13534: Add a linter rule for newlines after PHP open tags

Parents

rARC10f9c460fa0f: Remove leftover code for "postponed" lint and unit status

Branches

Unknown

Tags

Unknown

Event Timeline

joshuaspence committed rARCa5304e472d18: Add a linter rule for newlines after PHP open tags (authored by joshuaspence).Aug 30 2015, 8:49 PM

Changes (59)

Path

Size

src/

__phutil_library_map__.php

lint/

linter/

__tests__/

xhpast/

array-comma.lint-test

array-index.lint-test

blacklisted.lint-test

call-time-pass-by-reference.lint-test

cast-spacing.lint-test

class-name-literal.lint-test

constant-case.lint-test

constructor-parentheses.lint-test

default-parameters.lint-test

double-quote.lint-test

duplicate-key-in-array.lint-test

duplicate-switch-case.lint-test

dynamic-define.lint-test

elseif.lint-test

empty-block-statement.lint-test

empty-statement.lint-test

exit-expression.lint-test

formatted-string.lint-test

global-variables.lint-test

hash-comments.lint-test

implicit-visibility.lint-test

index-function.lint-test

instanceof-operator.lint-test

	invalid-default-parameter.lint-test
	invalid-default-paramter.lint-test

invalid-default-paramter.lint-test

invalid-modifiers.lint-test

lamba-func-function.lint-test

language-construct-parentheses.lint-test

list-assignment.lint-test

lowercase-functions.lint-test

modifier-ordering.lint-test

naming-conventions.lint-test

newline-after-open-tag.lint-test

no-segfault-on-abstract.lint-test

no-segfault-on-exit.lint-test

nowdoc.lint-test

object-operating-spacing.lint-test

parens-hug-contents.lint-test

php54-incompat.lint-test

preg-quote.lint-test

reused-iterator-reference.lint-test

reused-local.lint-test

semicolon-spacing.lint-test

single-pass-adjacent-patches.lint-test

space-after-control-keywords.lint-test

space-around-more-operators.lint-test

space-around-operators.lint-test

surprising-constructors.lint-test

tautological-expressions.lint-test

tostring-exception.lint-test

unary-postfix-expression-spacing.lint-test

unary-prefix-expression-spacing.lint-test

unnecessary-final-modifier.lint-test

unreasonably-deep-nesting.lint-test

use-of-this-in-static-method.lint-test

variable-variables.lint-test

wrong-concat-operator.lint-test

xhpast/

rules/

ArcanistNewlineAfterOpenTagXHPASTLinterRule.php

rARCa5304e472d18

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/tests/xhpast/array-comma.lint-test

View Options

src/lint/linter/tests/xhpast/array-index.lint-test

View Options

src/lint/linter/tests/xhpast/blacklisted.lint-test

View Options

src/lint/linter/tests/xhpast/call-time-pass-by-reference.lint-test

View Options

src/lint/linter/tests/xhpast/cast-spacing.lint-test

View Options

src/lint/linter/tests/xhpast/class-name-literal.lint-test

View Options

src/lint/linter/tests/xhpast/constant-case.lint-test

View Options

src/lint/linter/tests/xhpast/constructor-parentheses.lint-test

View Options

src/lint/linter/tests/xhpast/default-parameters.lint-test

View Options

src/lint/linter/tests/xhpast/double-quote.lint-test

View Options

src/lint/linter/tests/xhpast/duplicate-key-in-array.lint-test

View Options

src/lint/linter/tests/xhpast/duplicate-switch-case.lint-test

View Options

src/lint/linter/tests/xhpast/dynamic-define.lint-test

View Options

src/lint/linter/tests/xhpast/elseif.lint-test

View Options

src/lint/linter/tests/xhpast/empty-block-statement.lint-test

View Options

src/lint/linter/tests/xhpast/empty-statement.lint-test

View Options

src/lint/linter/tests/xhpast/exit-expression.lint-test

View Options

src/lint/linter/tests/xhpast/formatted-string.lint-test

View Options

src/lint/linter/tests/xhpast/global-variables.lint-test

View Options

src/lint/linter/tests/xhpast/hash-comments.lint-test

View Options

src/lint/linter/tests/xhpast/implicit-visibility.lint-test

View Options

src/lint/linter/tests/xhpast/index-function.lint-test

View Options

src/lint/linter/tests/xhpast/instanceof-operator.lint-test

View Options

src/lint/linter/tests/xhpast/invalid-default-parameter.lint-test

View Options

src/lint/linter/tests/xhpast/invalid-default-paramter.lint-test

View Options

src/lint/linter/tests/xhpast/invalid-modifiers.lint-test

View Options

src/lint/linter/tests/xhpast/lamba-func-function.lint-test

View Options

src/lint/linter/tests/xhpast/language-construct-parentheses.lint-test

View Options

src/lint/linter/tests/xhpast/list-assignment.lint-test

View Options

src/lint/linter/tests/xhpast/lowercase-functions.lint-test

View Options

src/lint/linter/tests/xhpast/modifier-ordering.lint-test

View Options

src/lint/linter/tests/xhpast/naming-conventions.lint-test

View Options

src/lint/linter/tests/xhpast/newline-after-open-tag.lint-test

View Options

src/lint/linter/tests/xhpast/no-segfault-on-abstract.lint-test

View Options

src/lint/linter/tests/xhpast/no-segfault-on-exit.lint-test

View Options

src/lint/linter/tests/xhpast/nowdoc.lint-test

View Options

src/lint/linter/tests/xhpast/object-operating-spacing.lint-test

View Options

src/lint/linter/tests/xhpast/parens-hug-contents.lint-test

View Options

src/lint/linter/tests/xhpast/php54-incompat.lint-test

View Options

src/lint/linter/tests/xhpast/preg-quote.lint-test

View Options

src/lint/linter/tests/xhpast/reused-iterator-reference.lint-test

View Options

src/lint/linter/tests/xhpast/reused-local.lint-test

View Options

src/lint/linter/tests/xhpast/semicolon-spacing.lint-test

View Options

src/lint/linter/tests/xhpast/single-pass-adjacent-patches.lint-test

View Options

src/lint/linter/tests/xhpast/space-after-control-keywords.lint-test

View Options

src/lint/linter/tests/xhpast/space-around-more-operators.lint-test

View Options

src/lint/linter/tests/xhpast/space-around-operators.lint-test

View Options

src/lint/linter/tests/xhpast/surprising-constructors.lint-test

View Options

src/lint/linter/tests/xhpast/tautological-expressions.lint-test

View Options

src/lint/linter/tests/xhpast/tostring-exception.lint-test

View Options

src/lint/linter/tests/xhpast/unary-postfix-expression-spacing.lint-test

View Options

src/lint/linter/tests/xhpast/unary-prefix-expression-spacing.lint-test

View Options

src/lint/linter/tests/xhpast/unnecessary-final-modifier.lint-test

View Options

src/lint/linter/tests/xhpast/unreasonably-deep-nesting.lint-test

View Options

src/lint/linter/tests/xhpast/use-of-this-in-static-method.lint-test

View Options

src/lint/linter/tests/xhpast/variable-variables.lint-test

View Options

src/lint/linter/tests/xhpast/wrong-concat-operator.lint-test

View Options

src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php

Add a linter rule for newlines after PHP open tagsa5304e472d18Actions

Description

Details

Event Timeline

Changes (59)

rARCa5304e472d18

src/__phutil_library_map__.php

src/lint/linter/__tests__/xhpast/array-comma.lint-test

src/lint/linter/__tests__/xhpast/array-index.lint-test

src/lint/linter/__tests__/xhpast/blacklisted.lint-test

src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test

src/lint/linter/__tests__/xhpast/cast-spacing.lint-test

src/lint/linter/__tests__/xhpast/class-name-literal.lint-test

src/lint/linter/__tests__/xhpast/constant-case.lint-test

src/lint/linter/__tests__/xhpast/constructor-parentheses.lint-test

src/lint/linter/__tests__/xhpast/default-parameters.lint-test

src/lint/linter/__tests__/xhpast/double-quote.lint-test

src/lint/linter/__tests__/xhpast/duplicate-key-in-array.lint-test

src/lint/linter/__tests__/xhpast/duplicate-switch-case.lint-test

src/lint/linter/__tests__/xhpast/dynamic-define.lint-test

src/lint/linter/__tests__/xhpast/elseif.lint-test

src/lint/linter/__tests__/xhpast/empty-block-statement.lint-test

src/lint/linter/__tests__/xhpast/empty-statement.lint-test

src/lint/linter/__tests__/xhpast/exit-expression.lint-test

src/lint/linter/__tests__/xhpast/formatted-string.lint-test

src/lint/linter/__tests__/xhpast/global-variables.lint-test

src/lint/linter/__tests__/xhpast/hash-comments.lint-test

src/lint/linter/__tests__/xhpast/implicit-visibility.lint-test

src/lint/linter/__tests__/xhpast/index-function.lint-test

src/lint/linter/__tests__/xhpast/instanceof-operator.lint-test

src/lint/linter/__tests__/xhpast/invalid-default-parameter.lint-test

src/lint/linter/__tests__/xhpast/invalid-default-paramter.lint-test

src/lint/linter/__tests__/xhpast/invalid-modifiers.lint-test

src/lint/linter/__tests__/xhpast/lamba-func-function.lint-test

src/lint/linter/__tests__/xhpast/language-construct-parentheses.lint-test

src/lint/linter/__tests__/xhpast/list-assignment.lint-test

src/lint/linter/__tests__/xhpast/lowercase-functions.lint-test

src/lint/linter/__tests__/xhpast/modifier-ordering.lint-test

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

src/lint/linter/__tests__/xhpast/newline-after-open-tag.lint-test

src/lint/linter/__tests__/xhpast/no-segfault-on-abstract.lint-test

src/lint/linter/__tests__/xhpast/no-segfault-on-exit.lint-test

src/lint/linter/__tests__/xhpast/nowdoc.lint-test

src/lint/linter/__tests__/xhpast/object-operating-spacing.lint-test

src/lint/linter/__tests__/xhpast/parens-hug-contents.lint-test

src/lint/linter/__tests__/xhpast/php54-incompat.lint-test

src/lint/linter/__tests__/xhpast/preg-quote.lint-test

src/lint/linter/__tests__/xhpast/reused-iterator-reference.lint-test

src/lint/linter/__tests__/xhpast/reused-local.lint-test

src/lint/linter/__tests__/xhpast/semicolon-spacing.lint-test

src/lint/linter/__tests__/xhpast/single-pass-adjacent-patches.lint-test

src/lint/linter/__tests__/xhpast/space-after-control-keywords.lint-test

src/lint/linter/__tests__/xhpast/space-around-more-operators.lint-test

src/lint/linter/__tests__/xhpast/space-around-operators.lint-test

src/lint/linter/__tests__/xhpast/surprising-constructors.lint-test

src/lint/linter/__tests__/xhpast/tautological-expressions.lint-test

src/lint/linter/__tests__/xhpast/tostring-exception.lint-test

src/lint/linter/__tests__/xhpast/unary-postfix-expression-spacing.lint-test

src/lint/linter/__tests__/xhpast/unary-prefix-expression-spacing.lint-test

src/lint/linter/__tests__/xhpast/unnecessary-final-modifier.lint-test

src/lint/linter/__tests__/xhpast/unreasonably-deep-nesting.lint-test

src/lint/linter/__tests__/xhpast/use-of-this-in-static-method.lint-test

src/lint/linter/__tests__/xhpast/variable-variables.lint-test

src/lint/linter/__tests__/xhpast/wrong-concat-operator.lint-test

src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php

Add a linter rule for newlines after PHP open tags
a5304e472d18
Actions

src/lint/linter/tests/xhpast/array-comma.lint-test

src/lint/linter/tests/xhpast/array-index.lint-test

src/lint/linter/tests/xhpast/blacklisted.lint-test

src/lint/linter/tests/xhpast/call-time-pass-by-reference.lint-test

src/lint/linter/tests/xhpast/cast-spacing.lint-test

src/lint/linter/tests/xhpast/class-name-literal.lint-test

src/lint/linter/tests/xhpast/constant-case.lint-test

src/lint/linter/tests/xhpast/constructor-parentheses.lint-test

src/lint/linter/tests/xhpast/default-parameters.lint-test

src/lint/linter/tests/xhpast/double-quote.lint-test

src/lint/linter/tests/xhpast/duplicate-key-in-array.lint-test

src/lint/linter/tests/xhpast/duplicate-switch-case.lint-test

src/lint/linter/tests/xhpast/dynamic-define.lint-test

src/lint/linter/tests/xhpast/elseif.lint-test

src/lint/linter/tests/xhpast/empty-block-statement.lint-test

src/lint/linter/tests/xhpast/empty-statement.lint-test

src/lint/linter/tests/xhpast/exit-expression.lint-test

src/lint/linter/tests/xhpast/formatted-string.lint-test

src/lint/linter/tests/xhpast/global-variables.lint-test

src/lint/linter/tests/xhpast/hash-comments.lint-test

src/lint/linter/tests/xhpast/implicit-visibility.lint-test

src/lint/linter/tests/xhpast/index-function.lint-test

src/lint/linter/tests/xhpast/instanceof-operator.lint-test

src/lint/linter/tests/xhpast/invalid-default-parameter.lint-test

src/lint/linter/tests/xhpast/invalid-default-paramter.lint-test

src/lint/linter/tests/xhpast/invalid-modifiers.lint-test

src/lint/linter/tests/xhpast/lamba-func-function.lint-test

src/lint/linter/tests/xhpast/language-construct-parentheses.lint-test

src/lint/linter/tests/xhpast/list-assignment.lint-test

src/lint/linter/tests/xhpast/lowercase-functions.lint-test

src/lint/linter/tests/xhpast/modifier-ordering.lint-test

src/lint/linter/tests/xhpast/naming-conventions.lint-test

src/lint/linter/tests/xhpast/newline-after-open-tag.lint-test

src/lint/linter/tests/xhpast/no-segfault-on-abstract.lint-test

src/lint/linter/tests/xhpast/no-segfault-on-exit.lint-test

src/lint/linter/tests/xhpast/nowdoc.lint-test

src/lint/linter/tests/xhpast/object-operating-spacing.lint-test

src/lint/linter/tests/xhpast/parens-hug-contents.lint-test

src/lint/linter/tests/xhpast/php54-incompat.lint-test

src/lint/linter/tests/xhpast/preg-quote.lint-test

src/lint/linter/tests/xhpast/reused-iterator-reference.lint-test

src/lint/linter/tests/xhpast/reused-local.lint-test

src/lint/linter/tests/xhpast/semicolon-spacing.lint-test

src/lint/linter/tests/xhpast/single-pass-adjacent-patches.lint-test

src/lint/linter/tests/xhpast/space-after-control-keywords.lint-test

src/lint/linter/tests/xhpast/space-around-more-operators.lint-test

src/lint/linter/tests/xhpast/space-around-operators.lint-test

src/lint/linter/tests/xhpast/surprising-constructors.lint-test

src/lint/linter/tests/xhpast/tautological-expressions.lint-test

src/lint/linter/tests/xhpast/tostring-exception.lint-test

src/lint/linter/tests/xhpast/unary-postfix-expression-spacing.lint-test

src/lint/linter/tests/xhpast/unary-prefix-expression-spacing.lint-test

src/lint/linter/tests/xhpast/unnecessary-final-modifier.lint-test

src/lint/linter/tests/xhpast/unreasonably-deep-nesting.lint-test

src/lint/linter/tests/xhpast/use-of-this-in-static-method.lint-test

src/lint/linter/tests/xhpast/variable-variables.lint-test

src/lint/linter/tests/xhpast/wrong-concat-operator.lint-test