Page MenuHomePhabricator
Differential D15123

Fix linter tests
Needs ReviewPublic
Actions

Authored by vm on Jan 28 2016, 12:14 AM.
Tags
None
Referenced Files
F19270969: D15123.diff
Mon, Dec 22, 10:36 PM
F18815842: D15123.diff
Oct 21 2025, 3:57 AM
F18777965: D15123.diff
Oct 11 2025, 6:52 AM
F18756534: D15123.id.diff
Oct 5 2025, 11:58 AM
F18713059: D15123.id.diff
Sep 29 2025, 5:36 AM
F18628009: D15123.id.diff
Sep 16 2025, 5:21 AM
F18622947: D15123.diff
Sep 15 2025, 1:38 PM
F18499917: D15123.diff
Sep 4 2025, 8:12 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

ArcanistClosureLinterTestCase was not updated with D14010 which
changed the API for ArcanistLinterTestCase.
ArcanistCpplintLinterTestCase was failing with Cppcheck 1.72

Test Plan

Linter test cases pass

Diff Detail

Repository
rARC Arcanist
Branch
fix_lint_test
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10353
Build 12624: arc lint + arc unit

Event Timeline

vm updated this revision to Diff 36513.Jan 28 2016, 12:14 AM
vm retitled this revision from to Fix linter tests.
vm updated this object.
vm edited the test plan for this revision. (Show Details)
vm added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 28 2016, 12:14 AM
Herald added a subscriber: Korvin. · View Herald Transcript

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
9 lines
cppcheck/
1 line

Diff 36513

View Options

src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/cppcheck/zblair.lint-test

Loading...
Phabricator · Built by Phacility