Page MenuHomePhabricator

Add a linter rule for newlines after PHP open tags

Authored by joshuaspence on Jul 2 2015, 9:43 PM.



<?php\n\n... is much easier to read than <?php\n.... Depends on D13889 and D13890.

Test Plan

Added unit tests.

Diff Detail

rARC Arcanist
Lint Not Applicable
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for newlines after PHP open tags.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.

I think this phrasing is maybe a little ambiguous, since it doesn't mean "a single newline character", but could be interpreted like that (i.e. "<?php\n1+1" has "a single newline character", but is not desired). Maybe "an empty line"?

This revision is now accepted and ready to land.Jul 2 2015, 9:48 PM

The fact that I needed to modify so many lint-test files was motivation for D14010.

This revision was automatically updated to reflect the committed changes.