Page MenuHomePhabricator

Support "Review Changes" and "Block Changes" settings for Owners package "Auto Review"
ClosedPublic

Authored by epriestley on May 13 2016, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 26, 8:34 AM
Unknown Object (File)
Sat, Sep 24, 4:00 PM
Unknown Object (File)
Sun, Sep 18, 11:30 PM
Unknown Object (File)
Sun, Sep 18, 11:29 PM
Unknown Object (File)
Sun, Sep 18, 11:29 PM
Unknown Object (File)
Sat, Sep 17, 12:50 AM
Unknown Object (File)
Sat, Sep 10, 5:14 PM
Unknown Object (File)
Fri, Sep 9, 5:41 PM
Subscribers
None

Details

Summary

Ref T10939. Fixes T8887. This enables and implements the "review" and "blocking review" options for packages.

This is a bit copy-pastey from DifferentialReviewersHeraldAction, which doesn't feel awesome. I think the right fix is Glorious Infrasturcture, though -- I filed T10967 to track that.

Test Plan
  • Set package autoreveiw to "Review".
  • Updated, got a reveiwer.
  • Set autoreview to "blocking".
  • Updated, got a blocking reviewer.

Screen Shot 2016-05-13 at 11.24.54 AM.png (157×516 px, 25 KB)

Screen Shot 2016-05-13 at 11.24.58 AM.png (108×434 px, 16 KB)

Screen Shot 2016-05-13 at 11.25.06 AM.png (211×405 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support "Review Changes" and "Block Changes" settings for Owners package "Auto Review".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:40 PM
This revision was automatically updated to reflect the committed changes.