Page MenuHomePhabricator

Support "Review Changes" and "Block Changes" settings for Owners package "Auto Review"
ClosedPublic

Authored by epriestley on May 13 2016, 6:30 PM.

Details

Summary

Ref T10939. Fixes T8887. This enables and implements the "review" and "blocking review" options for packages.

This is a bit copy-pastey from DifferentialReviewersHeraldAction, which doesn't feel awesome. I think the right fix is Glorious Infrasturcture, though -- I filed T10967 to track that.

Test Plan
  • Set package autoreveiw to "Review".
  • Updated, got a reveiwer.
  • Set autoreview to "blocking".
  • Updated, got a blocking reviewer.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38320.May 13 2016, 6:30 PM
epriestley retitled this revision from to Support "Review Changes" and "Block Changes" settings for Owners package "Auto Review".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.May 13 2016, 7:40 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:40 PM
This revision was automatically updated to reflect the committed changes.