HomePhabricator

Support "Review Changes" and "Block Changes" settings for Owners package…

Tags
None
Referenced Files
F1311721: Screen Shot 2016-05-13 at 11.24.58 AM.png
May 14 2016, 12:22 AM
F1311720: Screen Shot 2016-05-13 at 11.24.54 AM.png
May 14 2016, 12:22 AM
F1311722: Screen Shot 2016-05-13 at 11.25.06 AM.png
May 14 2016, 12:22 AM
Subscribers
None

Description

Support "Review Changes" and "Block Changes" settings for Owners package "Auto Review"

Summary:
Ref T10939. Fixes T8887. This enables and implements the "review" and "blocking review" options for packages.

This is a bit copy-pastey from DifferentialReviewersHeraldAction, which doesn't feel awesome. I think the right fix is Glorious Infrasturcture, though -- I filed T10967 to track that.

Test Plan:

  • Set package autoreveiw to "Review".
  • Updated, got a reveiwer.
  • Set autoreview to "blocking".
  • Updated, got a blocking reviewer.

Screen Shot 2016-05-13 at 11.24.54 AM.png (157×516 px, 25 KB)

Screen Shot 2016-05-13 at 11.24.58 AM.png (108×434 px, 16 KB)

Screen Shot 2016-05-13 at 11.25.06 AM.png (211×405 px, 29 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8887, T10939

Differential Revision: https://secure.phabricator.com/D15916