Page MenuHomePhabricator

Implement "Auto Review" in packages with a "Subscribe" option
ClosedPublic

Authored by epriestley on May 13 2016, 6:01 PM.
Tags
None
Referenced Files
F11160192: D15915.diff
Tue, Sep 27, 11:34 AM
Unknown Object (File)
Tue, Sep 27, 6:46 AM
Unknown Object (File)
Mon, Sep 26, 8:34 AM
Unknown Object (File)
Sun, Sep 25, 11:07 AM
Unknown Object (File)
Sun, Sep 25, 5:55 AM
Unknown Object (File)
Sat, Sep 24, 3:59 PM
Unknown Object (File)
Fri, Sep 23, 8:54 AM
Unknown Object (File)
Fri, Sep 23, 4:23 AM
Subscribers
None

Details

Summary

Ref T10939. Ref T8887. This moves toward letting packages automatically become reviewers or blocking reviewers of owned code.

This change adds an "Auto Review" option to packages. Because adding reviewers/blocking reviewers is a little tricky, it doesn't actually have these options yet -- just a "subscribe" option. I'll do the reviewer work in the next update.

Test Plan

Created a revision in a package with "Auto Review: Subscribe to Changes". The package got subscribed.

Screen Shot 2016-05-13 at 10.57.14 AM.png (220×524 px, 34 KB)

Screen Shot 2016-05-13 at 10.57.24 AM.png (260×533 px, 31 KB)

Screen Shot 2016-05-13 at 10.57.31 AM.png (192×606 px, 24 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement "Auto Review" in packages with a "Subscribe" option.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:38 PM
This revision was automatically updated to reflect the committed changes.