Page MenuHomePhabricator

Fix an issue where non-ID changeset state keys were used as changeset IDs
ClosedPublic

Authored by epriestley on May 4 2020, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 11:55 PM
Unknown Object (File)
Oct 22 2024, 5:51 AM
Unknown Object (File)
Oct 21 2024, 9:56 AM
Unknown Object (File)
Oct 7 2024, 6:06 AM
Unknown Object (File)
Sep 1 2024, 7:02 PM
Unknown Object (File)
Aug 19 2024, 10:31 PM
Unknown Object (File)
Aug 14 2024, 3:16 AM
Unknown Object (File)
Aug 12 2024, 6:12 PM
Subscribers
None

Details

Summary

Ref T13519. This is a little fuzzy, but I think the workflow here is:

  • View an intradiff, generating an ephemeral comparison changeset with no changeset ID. This produces a state key of "*".
  • Apply "hidden" state changes to the changeset.
  • View some other intradiff and/or diff view.
  • The code attempts to use "*" as a changset ID?

I'm not entirely sure this is accurate; this was observed in production and I couldn't get a clean reproduction case locally.

Optimistically, try making changeset IDs explicit rather than relying on state keys to be "usually changeset-ID-like".

Test Plan

Used "hidden" locally across multiple intradiffs, but I wasn't cleanly able to reproduce the initial issue.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable