Page MenuHomePhabricator

Fix an issue where non-ID changeset state keys were used as changeset IDs
ClosedPublic

Authored by epriestley on May 4 2020, 11:02 PM.
Tags
None
Referenced Files
F15444850: D21223.id50545.diff
Thu, Mar 27, 11:35 AM
F15439918: D21223.id.diff
Wed, Mar 26, 10:13 AM
F15437970: D21223.diff
Tue, Mar 25, 10:24 PM
F15418257: D21223.id50546.diff
Thu, Mar 20, 10:02 PM
F15338559: D21223.diff
Sun, Mar 9, 11:27 AM
F15333572: D21223.diff
Sat, Mar 8, 3:09 AM
F15331254: D21223.id.diff
Fri, Mar 7, 8:29 AM
Unknown Object (File)
Feb 21 2025, 11:35 AM
Subscribers
None

Details

Summary

Ref T13519. This is a little fuzzy, but I think the workflow here is:

  • View an intradiff, generating an ephemeral comparison changeset with no changeset ID. This produces a state key of "*".
  • Apply "hidden" state changes to the changeset.
  • View some other intradiff and/or diff view.
  • The code attempts to use "*" as a changset ID?

I'm not entirely sure this is accurate; this was observed in production and I couldn't get a clean reproduction case locally.

Optimistically, try making changeset IDs explicit rather than relying on state keys to be "usually changeset-ID-like".

Test Plan

Used "hidden" locally across multiple intradiffs, but I wasn't cleanly able to reproduce the initial issue.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable