Page MenuHomePhabricator

Fix an issue where non-ID changeset state keys were used as changeset IDs
ClosedPublic

Authored by epriestley on Mon, May 4, 11:02 PM.

Details

Summary

Ref T13519. This is a little fuzzy, but I think the workflow here is:

  • View an intradiff, generating an ephemeral comparison changeset with no changeset ID. This produces a state key of "*".
  • Apply "hidden" state changes to the changeset.
  • View some other intradiff and/or diff view.
  • The code attempts to use "*" as a changset ID?

I'm not entirely sure this is accurate; this was observed in production and I couldn't get a clean reproduction case locally.

Optimistically, try making changeset IDs explicit rather than relying on state keys to be "usually changeset-ID-like".

Test Plan

Used "hidden" locally across multiple intradiffs, but I wasn't cleanly able to reproduce the initial issue.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 4, 11:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 11:03 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.