Page MenuHomePhabricator

Fix an issue where non-ID changeset state keys were used as changeset IDs
ClosedPublic

Authored by epriestley on May 4 2020, 11:02 PM.
Tags
None
Referenced Files
F14754697: D21223.id50545.diff
Tue, Jan 21, 3:37 PM
F14754453: D21223.id50545.diff
Tue, Jan 21, 3:32 PM
Unknown Object (File)
Tue, Jan 21, 12:47 PM
Unknown Object (File)
Mon, Jan 13, 7:30 AM
Unknown Object (File)
Fri, Jan 3, 11:25 AM
Unknown Object (File)
Fri, Jan 3, 4:56 AM
Unknown Object (File)
Thu, Jan 2, 7:53 PM
Unknown Object (File)
Dec 21 2024, 2:06 AM
Subscribers
None

Details

Summary

Ref T13519. This is a little fuzzy, but I think the workflow here is:

  • View an intradiff, generating an ephemeral comparison changeset with no changeset ID. This produces a state key of "*".
  • Apply "hidden" state changes to the changeset.
  • View some other intradiff and/or diff view.
  • The code attempts to use "*" as a changset ID?

I'm not entirely sure this is accurate; this was observed in production and I couldn't get a clean reproduction case locally.

Optimistically, try making changeset IDs explicit rather than relying on state keys to be "usually changeset-ID-like".

Test Plan

Used "hidden" locally across multiple intradiffs, but I wasn't cleanly able to reproduce the initial issue.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable