When publishing a commit, copy "Related Tasks" from the associated revision (if one exists)
ClosedPublic
Actions

Authored by epriestley on Thu, Jan 30, 6:32 PM.

Details

Reviewers: None
Maniphest Tasks: T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx"
Commits: rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if…

Summary

Fixes T13463. Currently, if you use the web UI to set "Related Tasks" for a revision, the resulting commit does not link to the tasks.

If you use "Ref ..." in the message instead, the resulting commit does link to the tasks.

Broadly, this should all be cleaner (see T3577) but we can step toward better behavior by just copying these edges when commits are published.

Test Plan

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

epriestley requested review of this revision.Thu, Jan 30, 6:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Feb 4, 3:05 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/applications/audit/editor/PhabricatorAuditEditor.php (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49937	ccf28a8		Thu, Jan 30, 6:32 PM	★	★
Diff 2	49951	530145b	rP4904d7711ea14383a35c9c33249551771ba64f97	Tue, Feb 4, 3:05 PM	★	★