Page MenuHomePhabricator

Restore "h" to hide or show files, and modernize file visibility toggling
ClosedPublic

Authored by epriestley on May 17 2017, 7:54 PM.
Tags
None
Referenced Files
F19829364: D17940.id.diff
Mar 10 2026, 4:29 AM
F19821247: D17940.diff
Mar 6 2026, 8:09 PM
F19794155: D17940.id43172.diff
Feb 26 2026, 6:28 PM
F19659880: D17940.diff
Feb 7 2026, 1:58 AM
F19434354: D17940.id43172.diff
Dec 28 2025, 2:26 PM
F19259089: D17940.diff
Dec 22 2025, 3:13 PM
F19096197: D17940.diff
Dec 4 2025, 8:57 AM
F19095485: D17940.diff
Dec 4 2025, 5:14 AM
Subscribers
None

Details

Summary

Ref T12616. This puts "h" back to collapse or expand the current file.

This removes some very complicated/messy code around following links in the table of contents and getting files auto-expanded. I suspect no one will miss this, but we can restore it if ayone notices.

Test Plan

Pressed "h" to collapse/expand a file. Also used the menu items.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

webroot/rsrc/css/application/differential/changeset-view.css
328

This at least makes the weird collapsed state a little less weird/goofy looking (see T12688).

webroot/rsrc/js/application/diff/DiffChangesetList.js
369–386

Oops, some copy-paste slipup nonsense here, one sec.

  • Copy/paste with greater finesse.
This revision is now accepted and ready to land.May 18 2017, 3:02 PM
This revision was automatically updated to reflect the committed changes.