Page MenuHomePhabricator

Restore "h" to hide or show files, and modernize file visibility toggling
ClosedPublic

Authored by epriestley on May 17 2017, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 9, 4:09 AM
Unknown Object (File)
Wed, Aug 3, 11:01 PM
Unknown Object (File)
Sun, Jul 31, 2:58 PM
Unknown Object (File)
Tue, Jul 26, 12:36 AM
Unknown Object (File)
Fri, Jul 22, 5:09 AM
Unknown Object (File)
Sat, Jul 16, 9:49 AM
Unknown Object (File)
Fri, Jul 15, 4:33 PM
Unknown Object (File)
Thu, Jul 14, 9:50 AM
Subscribers
None

Details

Summary

Ref T12616. This puts "h" back to collapse or expand the current file.

This removes some very complicated/messy code around following links in the table of contents and getting files auto-expanded. I suspect no one will miss this, but we can restore it if ayone notices.

Test Plan

Pressed "h" to collapse/expand a file. Also used the menu items.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

webroot/rsrc/css/application/differential/changeset-view.css
328

This at least makes the weird collapsed state a little less weird/goofy looking (see T12688).

webroot/rsrc/js/application/diff/DiffChangesetList.js
369–386

Oops, some copy-paste slipup nonsense here, one sec.

  • Copy/paste with greater finesse.
This revision is now accepted and ready to land.May 18 2017, 3:02 PM
This revision was automatically updated to reflect the committed changes.