[Draft] Posting this up because feed is pulling getTitle and not getTitleForFeed and I'm super confused. Restarted phd and apache.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T11645: Generate feed story for new (all user) rooms?
- Commits
- rP1ea6fe938744: Add basic feed stories for Conpherence
Create a new room, see link in feed. Change topic, see story, add people, don't see story.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/conpherence/storage/ConpherenceTransaction.php | ||
|---|---|---|
| 151 | This just sets a variable called $title, it doesn't return it or do anything with it. Then it calls parent::getTitleForFeed(), which calls getTitle() as a fallback. | |
| src/applications/conpherence/storage/ConpherenceTransaction.php | ||
|---|---|---|
| 151 | oh | |
Comment Actions
Only thing I can't seem to get working is the first CREATE transaction, it doesn't trigger TYPE_TITLE. Seems to trigger PARTICIPANTS.
Comment Actions
Taskmaster debug command is:
$ bin/phd debug taskmasterThe creation stuff is sort of written questionably right now, but I think it's not worth correcting before moving to modular transactions to fix it properly.
"Participants" wins over "Title" as the topic for the feed story because both of these conditions are true:
- it's earlier in the transaction list in ConpherenceNewRoomController; and
- there's no getActionStrength() stuff to force the transactions into a different order.
Easiest fix is likely to reorder the transactions in ConpherenceNewRoomController so that TYPE_TITLE is first.
| src/applications/conpherence/storage/ConpherenceTransaction.php | ||
|---|---|---|
| 136 | This probably misbehaves when renaming a room from "0" to "Zebra", or from "Zebra" to "0". | |
| 152–163 | Likewise, we probably get into trouble here when setting the topic to or from "0". | |
| 160 | This puts double quotes around a handle, which is unusual. | |
Comment Actions
This feels pretty reasonable to me overall, but miggghht? be weird in some cases? I think if we add DM explicitly, those shouldn't generate feed, but Rooms with n participants should.