Page MenuHomePhabricator

Make collapsed inlines more useful and anchor target highlights more accurate
ClosedPublic

Authored by epriestley on May 16 2017, 6:06 PM.
Tags
None
Referenced Files
F19510346: D17913.diff
Sun, Jan 11, 7:55 AM
F19081224: D17913.id43091.diff
Dec 2 2025, 4:38 AM
F18764010: D17913.diff
Oct 7 2025, 3:39 AM
F18749685: D17913.id.diff
Oct 4 2025, 4:46 AM
F18745948: D17913.diff
Oct 3 2025, 10:29 AM
F18723894: D17913.id43088.diff
Sep 30 2025, 2:18 AM
F18508810: D17913.id.diff
Sep 5 2025, 3:02 AM
F18501066: D17913.diff
Sep 4 2025, 9:31 PM
Subscribers
None

Details

Summary

Ref T12616. Fixes T11648. Currently, we snug up replies with a negative margin (from T10563) but this throws off the anchor highlighting.

Instead:

  • Remove padding from these dolumns.
  • Use margins on the stuff inside them instead.
  • Less margins for replies.
  • Less margins for collapsed comments.
  • Show some text for collapsed comments.
Test Plan

Screen Shot 2017-05-16 at 10.55.13 AM.png (250×766 px, 23 KB)

Screen Shot 2017-05-16 at 10.57.37 AM.png (249×1 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I have it on good authority td stands for table data. TIL

This revision is now accepted and ready to land.May 16 2017, 6:08 PM
This revision was automatically updated to reflect the committed changes.