Page MenuHomePhabricator

Make collapsed inlines more useful and anchor target highlights more accurate
ClosedPublic

Authored by epriestley on May 16 2017, 6:06 PM.
Tags
None
Referenced Files
F15422092: D17913.id.diff
Sat, Mar 22, 5:25 AM
F15420156: D17913.diff
Fri, Mar 21, 11:51 AM
F15375433: D17913.diff
Wed, Mar 12, 11:11 PM
Unknown Object (File)
Mon, Feb 24, 12:57 PM
Unknown Object (File)
Jan 24 2025, 6:10 PM
Unknown Object (File)
Jan 24 2025, 1:08 PM
Unknown Object (File)
Jan 22 2025, 4:53 PM
Unknown Object (File)
Jan 21 2025, 10:20 AM
Subscribers
None

Details

Summary

Ref T12616. Fixes T11648. Currently, we snug up replies with a negative margin (from T10563) but this throws off the anchor highlighting.

Instead:

  • Remove padding from these dolumns.
  • Use margins on the stuff inside them instead.
  • Less margins for replies.
  • Less margins for collapsed comments.
  • Show some text for collapsed comments.
Test Plan

Screen Shot 2017-05-16 at 10.55.13 AM.png (250×766 px, 23 KB)

Screen Shot 2017-05-16 at 10.57.37 AM.png (249×1 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I have it on good authority td stands for table data. TIL

This revision is now accepted and ready to land.May 16 2017, 6:08 PM
This revision was automatically updated to reflect the committed changes.