Page MenuHomePhabricator

Make collapsed inlines more useful and anchor target highlights more accurate
ClosedPublic

Authored by epriestley on May 16 2017, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 17, 11:15 AM
Unknown Object (File)
Thu, Sep 15, 2:12 PM
Unknown Object (File)
Wed, Sep 14, 11:18 PM
Unknown Object (File)
Mon, Sep 12, 8:45 AM
Unknown Object (File)
Sat, Sep 10, 7:03 AM
Unknown Object (File)
Sun, Sep 4, 7:37 AM
Unknown Object (File)
Sat, Sep 3, 10:28 PM
Unknown Object (File)
Fri, Sep 2, 3:35 AM
Subscribers
None

Details

Summary

Ref T12616. Fixes T11648. Currently, we snug up replies with a negative margin (from T10563) but this throws off the anchor highlighting.

Instead:

  • Remove padding from these dolumns.
  • Use margins on the stuff inside them instead.
  • Less margins for replies.
  • Less margins for collapsed comments.
  • Show some text for collapsed comments.
Test Plan

Screen Shot 2017-05-16 at 10.55.13 AM.png (250×766 px, 23 KB)

Screen Shot 2017-05-16 at 10.57.37 AM.png (249×1 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I have it on good authority td stands for table data. TIL

This revision is now accepted and ready to land.May 16 2017, 6:08 PM
This revision was automatically updated to reflect the committed changes.