Paths

Table of Contentst

Differential D16480

Correctly calculate "any_failed"
ClosedPublic
Actions

Authored by avivey on Aug 31 2016, 9:29 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10746: Aborted build in Harbormaster still shows as building in Diffusion

Commits

rP25a7266d15dc: Correctly calculate "any_failed"

Summary

See T10746.

Test Plan

Fail one of several builds, run ./bin/harbormaster update, see that Build Status is Failed.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey updated this revision to Diff 39653.Aug 31 2016, 9:29 PM

avivey retitled this revision from to Correctly calculate "any_failed".

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a task: T10746: Aborted build in Harbormaster still shows as building in Diffusion.

avivey added a subscriber: yelirekim.

Owners added a subscriber: Restricted Owners Package.Aug 31 2016, 9:29 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 31 2016, 9:29 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Doesn't actually fix the Abort case in T10746, just the Failed case.

Ack, looks like I missed this in review in D16348. Thanks!

This revision is now accepted and ready to land.Aug 31 2016, 9:35 PM

Closed by commit rP25a7266d15dc: Correctly calculate "any_failed" (authored by avivey, committed by avivey). · Explain WhyAug 31 2016, 9:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

engine/

HarbormasterBuildEngine.php

7 lines

Diff 39654

View Options

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Correctly calculate "any_failed"ClosedPublicActions