Improve mobile/device behaviors for inline comments
343f7cac72bb
Actions

Description

Improve mobile/device behaviors for inline comments

Summary: Fixes T1026. Ref T12616. Allows drag-to-select on devices to add inlines on a range of lines, using dark magic that I copy/pasted from StackOverflow.

Test Plan: Left a comment on a range of lines on iPhone simulator.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12616, T1026

Differential Revision: https://secure.phabricator.com/D17928

Details

Provenance

epriestley	Authored on May 17 2017, 2:38 PM
epriestley	Pushed on May 17 2017, 3:53 PM

Reviewer

chad

Differential Revision

D17928: Improve mobile/device behaviors for inline comments

Parents

rP51df02821b86: Move the "select a line range" inline code to DiffInline

Branches

Unknown

Tags

Unknown

Tasks

T12616: Modernize display code for inline comments
T1026: Request: ability to select line range for comment via touchscreen

Build Status

Buildable 17051
Build 22803: Run Core Tests

Event Timeline

epriestley committed rP343f7cac72bb: Improve mobile/device behaviors for inline comments (authored by epriestley).May 17 2017, 3:53 PM

epriestley added a task: T12616: Modernize display code for inline comments.

epriestley added a task: T1026: Request: ability to select line range for comment via touchscreen.

Harbormaster completed building B17051: rP343f7cac72bb: Improve mobile/device behaviors for inline comments.May 17 2017, 3:55 PM

Changes (2)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

rP343f7cac72bb

View Options

resources/celerity/map.php